1576040 - Wrench builds don't trigger when changing the rust compiler

Status: NEW

(Firefox Build System :: Task Configuration, task)

Description

[Narcis Beleuzu [:NarcisB]]

As shown in bug 1576034, Rust compiler updates can break wrench tests and the resulting bustage may not be noticed until days later due to the infrequency with which they're triggered. We should also include the Rust compiler in the files-changed list

Comment 1

[Mike Hommey [:glandium]]

There's not really a "files-changed" that could be added. The closest would be taskcluster/ci/toolchain/rust.yml, but that would trigger those tasks on any unrelated rust change.

What puzzles me, though, is why they're not happening when their dependency happen: When a docker-image happens, toolchains that depend on the docker-image happen. Why are we not in the same situation here?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I'm not the right person to answer that question.

Comment 3

[Tom Prince [:tomprince]]

(In reply to Mike Hommey [:glandium] from comment #1)

What puzzles me, though, is why they're not happening when their dependency happen: When a docker-image happens, toolchains that depend on the docker-image happen. Why are we not in the same situation here?

They get rebuild when the docker-images get rebuilt if they are in the target graph. Some of the toolchains get pulled in explicitly (run-on-projects) and others get pulled in as dependencies of other things (everything involved in builds, for example). If wrench-tests only run when stuff in gfx/webrender runs, they probably won't be in the graph when the rust toolchain is rebuilt.