1576076 - Latin1 strings: Add a Latin1 flavor of JSExternalString

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

To enable buffer sharing of DOM ByteString, let's add a Latin1 flavor of JSExternalString.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: WIP: Bug 1576076 - Support Latin1Char in JSExternalString.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1576076 - Part 1: Rename existing ExternalString APIs to use ExternalUCString. r?sfink!

In order to avoid confusion and collision with Latin1 flavor, rename existing
APIs to use UC prefix.
Latin1 flavor usually doesn't have any prefix/suffix, but the next patch uses
ExternalStringLatin1, to avoid another confusion with current UTF-16 APIs.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1576076 - Part 2: Support Latin1Char in JSExternalString. r?sfink!

Adds:

• JS_NewExternalStringLatin1
• JS_NewMaybeExternalStringLatin1
• IsExternalStringLatin1
• latin1 methods for JSExternalStringCallbacks

Depends on D194672

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b98a0b46db4
Part 1: Rename existing ExternalString APIs to use ExternalUCString. r=sfink
https://hg.mozilla.org/integration/autoland/rev/90b59d83622d
Part 2: Support Latin1Char in JSExternalString. r=sfink

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4b98a0b46db4
https://hg.mozilla.org/mozilla-central/rev/90b59d83622d