Closed Bug 1576079 Opened 4 months ago Closed 3 months ago

Only build binast when building Spidermonkey standalon

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task
Priority:
Not set

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1576079 - Only build binast when building Spidermonkey standalone.
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

Bug 1454613 enabled binast (binsource back then) so that automation
would catch trivial build errors. The caveat is that it incurs build
times for everyone, while the tool is not even used during the build:
the result of running it is checked in in the tree.

Ideally, it would be built in entirely separate tasks, but the overhead
of setting up a task (checking out the repository, downloading
toolchains, etc.) is actually large enough that it's overkill to build
completely separately.

However, it makes sense to limit to spidermonkey standalone builds.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/269342eafa4b
Only build binast when building Spidermonkey standalone. r=nalexander

https://hg.mozilla.org/mozilla-central/rev/269342eafa4b

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.