Closed Bug 1576092 Opened 4 months ago Closed 4 months ago

Fix the breadcrumbs' arrow borders colors for white theme

Categories

(DevTools :: Inspector, enhancement)

enhancement
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

References

Details

Attachments

(3 files)

This is a followup from bug 1574520.
Quoting from gl:

I am not quite sure we should fix the border colours with this patch. Using --theme-splitter-color here doesn't seem correct to me since we used to have an opacity of .1, and the border was never really visible in the light theme. My suggestion would be to move this change to a different bug and we can have Victoria's UX input.

Currently the border color is set to rgba(255, 255, 255, .1) which is undistinguishable in white theme, and can only be seen in dark theme.
My suggestion is to change it to something like -theme-splitter-color so it could be seen in white theme as well.

See attached for before & after the change for white and dark themes.

Attached image Before
Attached image After

Gabriel, kindly ni? the correct person.

Flags: needinfo?(gl)
Flags: needinfo?(gl) → needinfo?(victoria)

Yes, this looks good. Thanks Itiel!

Flags: needinfo?(victoria)
Flags: needinfo?(itiel_yn8)
Flags: needinfo?(itiel_yn8)
Keywords: checkin-needed

Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86e40759a597
Fix the breadcrumbs' arrow border color for white theme r=gl

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → itiel_yn8
You need to log in before you can comment on or make changes to this bug.