Closed Bug 1576097 Opened 4 months ago Closed 4 months ago

Deal with config.status breakage more gracefully

Categories

(Firefox Build System :: General, task)

task
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(2 files)

No description provided.

As seen in bug 1575774/1575959, things can go badly when config.status
doesn't match expectations, especially when most mach commands try to
read it, starting with mach clobber, which is supposed to be the one
commant to get away from most problems.

The idea here is to throw a recognizable exception so that callers can
react accordingly. While not obvious from the patch, the result is that
running e.g. mach build with a broken config.status will automatically
run configure (because the relevant caller actually handles the rethrown
exception that way).

There are other calls to from_config_status in the mozbuild reader, but
that can't be reached before MozbuildObject.config_environment.

This time, existing config.status trying to import it will throw an exception
that will trigger a re-configure.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/c4c43bf71488
Deal with config.status breakage more gracefully. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/014630236d2d
Remove mozbuild.util.encode again. r=nalexander
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.