Deal with config.status breakage more gracefully
Categories
(Firefox Build System :: General, task)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(2 files)
|
Assignee | |
Comment 1•5 years ago
|
||
As seen in bug 1575774/1575959, things can go badly when config.status
doesn't match expectations, especially when most mach commands try to
read it, starting with mach clobber, which is supposed to be the one
commant to get away from most problems.
The idea here is to throw a recognizable exception so that callers can
react accordingly. While not obvious from the patch, the result is that
running e.g. mach build with a broken config.status will automatically
run configure (because the relevant caller actually handles the rethrown
exception that way).
There are other calls to from_config_status in the mozbuild reader, but
that can't be reached before MozbuildObject.config_environment.
|
|
Assignee | |
Comment 2•5 years ago
|
||
This time, existing config.status trying to import it will throw an exception
that will trigger a re-configure.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/c4c43bf71488 Deal with config.status breakage more gracefully. r=nalexander https://hg.mozilla.org/integration/autoland/rev/014630236d2d Remove mozbuild.util.encode again. r=nalexander
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c4c43bf71488
https://hg.mozilla.org/mozilla-central/rev/014630236d2d
Description
•