1576221 - "Contribute" button on add-on detail page doesn't work (STR in comment #6)

Status: RESOLVED DUPLICATE of bug 1500895

(Thunderbird :: Untriaged, defect)

Description

[giant+github]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. Go to the addon manager
2. Click on more
3. Click on the donate button
   I have version 60.8.0; dont know wether its version 60 or 68

Actual results:

Nothing

Expected results:

The button should redirect me to the donate platform.

Comment 1

[Jorg K (CEST = GMT+2)]

60.8.0 is part of the 60 series. Can you try this in TB 68 (pre-release) from here: http://ftp.mozilla.org/pub/thunderbird/candidates/68.0-candidates/build4/ or TB 69 beta.

Comment 2

[giant+github]

Tested with 68 and 69, issue still there for me.

Comment 3

[Jorg K (CEST = GMT+2)]

The trouble is, on Windows, I don't see a "more" to click on.

Magnus, where is that donate button?

Comment 4

[giant+github]

You can double-click too and not every addon has donate button.

Comment 5

[giant+github]

(In reply to Jorg K (GMT+2) from comment #3)

The trouble is, on Windows, I don't see a "more" to click on.

Magnus, where is that donate button?

I tested it with the addon Enigmail.

Comment 6

[Jorg K (CEST = GMT+2)]

STR:

1. Open add-on manager.
2. Click on an add-on to get to its details. Use an add-on that accepts donations, like Enigmail or Lightning
3. Click on the "Contribute" button.

Nothing happens. In the error console we get:
NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative contentAreaUtils.js:1226
openURL chrome://global/content/contentAreaUtils.js:1226
doCommand chrome://mozapps/content/extensions/extensions.js:1374
doCommand chrome://mozapps/content/extensions/extensions.js:1489
initialize chrome://mozapps/content/extensions/extensions.js:123

The offending code is this:

    if (channel) {
      channel.channelIsForDownload = true;
    }

Comment 7

[Andrei Hajdukewycz [:sancus]]

This is a dupe of bug 1500895 but since jorg has made useful comments on this one I'll leave it to him to decide which way to dupe.

According to the last comment in that bug, this works in daily, so maybe the fix can just be backported? I don't know.

Comment 8

[Jorg K (CEST = GMT+2)]

Sigh, I was pretty sure I had seen this before, but I was looking for "donate" not "contribute".