1576252 - move urlClassification out of common data

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Since it is privileged data, it needs to happen per extension rather than in common data which is shared.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1576252 move urlClassification to per-extension request data

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8628b6ec7506
move urlClassification to per-extension request data r=rpl

Comment 3

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 8628b6ec7506 (bug 1576252) for multiple failures at components/extensions/test/xpcshell/test_webRequest_filtering.js

Backout: https://hg.mozilla.org/integration/autoland/rev/996ae56a62134d46e0bb460857d33af8eff8ff02

Failure logs:
mochitest: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263247110&repo=autoland&lineNumber=2551

xpcshell: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263250657&repo=autoland&lineNumber=3163

browser-chrome: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263247425&repo=autoland&lineNumber=16379

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/558f8555b78f
move urlClassification to per-extension request data r=rpl

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/558f8555b78f

Comment 6

[Julien Cristau [:jcristau]]

AIUI bug 1564594 depends on this, and wants uplift to esr68. Would you mind requesting uplift here as well?

Comment 7

[Shane Caraveo (:mixedpuppy)]

(In reply to Julien Cristau [:jcristau] from comment #6)

AIUI bug 1564594 depends on this, and wants uplift to esr68. Would you mind requesting uplift here as well?

Are you sure you're asking on the correct bug?

This is a fix on code that landed in Fx70 in bug 1547140, I don't see how anything could depend on this and need uplift.

Comment 8

[Julien Cristau [:jcristau]]

I was basing this on https://bugzilla.mozilla.org/show_bug.cgi?id=1564594#c34 but it sounds like this doesn't actually affect esr68. Sorry for the noise.

Comment 9

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 10

[Shane Caraveo (:mixedpuppy)]

(In reply to Julien Cristau [:jcristau] from comment #8)

it sounds like this doesn't actually affect esr68

Ok, it wouldn't be a problem there.