Closed Bug 1576252 Opened 4 months ago Closed 4 months ago

move urlClassification out of common data

Categories

(WebExtensions :: Request Handling, defect, P1)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

(Whiteboard: [test-isolation-backout])

Attachments

(1 file)

Since it is privileged data, it needs to happen per extension rather than in common data which is shared.

Blocks: 1576042
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8628b6ec7506
move urlClassification to per-extension request data r=rpl
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/558f8555b78f
move urlClassification to per-extension request data r=rpl
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

AIUI bug 1564594 depends on this, and wants uplift to esr68. Would you mind requesting uplift here as well?

(In reply to Julien Cristau [:jcristau] from comment #6)

AIUI bug 1564594 depends on this, and wants uplift to esr68. Would you mind requesting uplift here as well?

Are you sure you're asking on the correct bug?

This is a fix on code that landed in Fx70 in bug 1547140, I don't see how anything could depend on this and need uplift.

Flags: needinfo?(mixedpuppy) → needinfo?(jcristau)

I was basing this on https://bugzilla.mozilla.org/show_bug.cgi?id=1564594#c34 but it sounds like this doesn't actually affect esr68. Sorry for the noise.

Flags: needinfo?(jcristau)

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Flags: needinfo?(mixedpuppy)
Whiteboard: [test-isolation-backout]

(In reply to Julien Cristau [:jcristau] from comment #8)

it sounds like this doesn't actually affect esr68

Ok, it wouldn't be a problem there.

Flags: needinfo?(mixedpuppy) → qe-verify-
Whiteboard: [test-isolation-backout] → [test isolation backout]
Whiteboard: [test isolation backout] → [test-isolation-backout]
You need to log in before you can comment on or make changes to this bug.