1576352 - "What should Firefox do with this file" "save" button's focused state not invalidated correctly when tabbing around the dialog

Status: REOPENED

(Core :: Graphics, defect, P2)

Description

[Marian]

Attachment: Preview.gif

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Open the "Save File" dialog.

1. Use tab to focus the next radio button (Is not working, is skiped to 'Save' button)
2. The 'Save' button border is glitched, if i use Tab to move the focus forward appear a strange border on top. If i use Shift+Tab to move Backward appears a border to bottom.

Comment 1

[Hani Yacoub, Desktop QA]

I couldn't reproduce the issue on Windows 10 x64 on Firefox Nightly 70.0a1, Firefox 69.0b16 and on Firefox 68.0.2.

Could you please try to reproduce the issue using a fresh profile? You have the steps here: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Thanks.

Comment 2

[Marian]

Yes. I can reproduce in all of these.

The Nighty and 69.0b16 are the same behavior. The border stay on the entire button, no cuts. But is still there.
In normal version the border is cutting.

https://drive.google.com/open?id=1QUuyO8Jlj9veM7QgQv1tzCUGQnSr3BMJ

Comment 3

[Marian]

What version of Windows 10 du you have ?. I have the 1809 17763.107

Comment 4

[Hani Yacoub, Desktop QA]

Assigning "Firefox: File Handling" component for it.

Comment 5

[:Gijs (he/him)]

Sorry, I'm a little confused by this report. When you say the button is "broken", you mean that visually, the blue outline on the "OK" button is incomplete when selecting it using the [Tab] key, right?

Activating the button still works?

And the blue outline is correct on Nightly?

Comment 6

[Marian]

Button works OK. Only the visual is broken.

If possible the radio button for "Save File" is skipped by the tab button and i don't know why.

Comment 7

[:Gijs (he/him)]

(In reply to Andronachi Marian from comment #6)

Button works OK. Only the visual is broken.

Thanks for clarifying. Because this is working for you in more recent versions of Firefox, I think I will close this report "works for me". Firefox 69 was released this week, and it looks like it was fixed there - I don't see you testing 69 in the gif, but comment #2 says you tried 69.0b16 and it was the same as 70/nightly, so I think this is now fixed if you update to 69 release. :-)

If possible the radio button for "Save File" is skipped by the tab button and i don't know why.

This is normal - you can use the up/down arrow keys to navigate between radio buttons. You can see the same behaviour for the tab key in other Windows app, for instance in Notepad: File -> Page Setup... - then tab through the portrait/landscape option. There's only one tabstop, and up/down arrows switch the selection.

Comment 8

[Marian]

Still broken the BackTab when using 'Shift+Tab'. On version 69

And when the Cancel button is Focused, the Save button still have the Blue Border.

https://youtu.be/1Gu0RoFcXko

Comment 9

[:Gijs (he/him)]

(In reply to Andronachi Marian from comment #8)

Still broken the BackTab when using 'Shift+Tab'. On version 69

And when the Cancel button is Focused, the Save button still have the Blue Border.

https://youtu.be/1Gu0RoFcXko

Ah, hm, that's not great. Let's reopen and move to graphics, then, as this seems like a graphics issue.

Comment 10

[Kelsey Gilbert [:jgilbert]]

This feels like it might be webrender related.

Can you attach an about:support?

Comment 11

[Marian]

Attachment: Firefox-Support.txt

Sure.

Comment 12

[Glenn Watson [:gw]]

From the support log, it looks like WR is not enabled. It says:

Compositing: Direct3D 11 (Advanced Layers)

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Andronachi, is this a regression? Did it work in older versions of Firefox? If it is, can you get a regression window using https://mozilla.github.io/mozregression/?

Comment 14

[Marian]

Hi. I don't know how to use that software. But instated i download all versions before 69 from 'https://ftp.mozilla.org/' and the latest versions that is working how supposed to be is 53.0.

Here is the video:
https://youtu.be/siDHUwAcu0M

Comment 15

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issue on Windows 10x64 with a Nightly build from 2019-07-20.

• Mozregression results:
• Push Log url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=255753135a7fb4821e52b8e1d47a9bf3bcbc78bd&tochange=cd94fba048645c2e73776138aac06c1b85ad334b
• 2019-09-12T02:49:27: DEBUG : Found commit message:
  Bug 1496425 - Provide a mechanism for Custom Elements to delay connectedCallback until after DOMContentLoaded;r=paolo

Comment 16

[:Gijs (he/him)]

(In reply to Gabi Cheta [:Gabi] Release Desktop QA from comment #15)

Reproduced the issue on Windows 10x64 with a Nightly build from 2019-07-20.

• Mozregression results:
• Push Log url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=255753135a7fb4821e52b8e1d47a9bf3bcbc78bd&tochange=cd94fba048645c2e73776138aac06c1b85ad334b
• 2019-09-12T02:49:27: DEBUG : Found commit message:
  Bug 1496425 - Provide a mechanism for Custom Elements to delay connectedCallback until after DOMContentLoaded;r=paolo

This conflicts with comment #14 as this is the Fx 64 nightly cycle and comment #14 indicated everything from Fx 54 was broken.

The commit message seems like a strange thing to pick; the range has a number of bugs, and bug 1475139 as work that touches graphics/painting seems more plausible (but still unlikely, given the previous point).

Comment 17

[Gabi Cheta [:Gabi] Desktop QA]

(In reply to :Gijs (he/him) from comment #16)

(In reply to Gabi Cheta [:Gabi] Release Desktop QA from comment #15)

Reproduced the issue on Windows 10x64 with a Nightly build from 2019-07-20.

• Mozregression results:
• Push Log url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=255753135a7fb4821e52b8e1d47a9bf3bcbc78bd&tochange=cd94fba048645c2e73776138aac06c1b85ad334b
• 2019-09-12T02:49:27: DEBUG : Found commit message:
  Bug 1496425 - Provide a mechanism for Custom Elements to delay connectedCallback until after DOMContentLoaded;r=paolo

This conflicts with comment #14 as this is the Fx 64 nightly cycle and comment #14 indicated everything from Fx 54 was broken.

The commit message seems like a strange thing to pick; the range has a number of bugs, and bug 1475139 as work that touches graphics/painting seems more plausible (but still unlikely, given the previous point).

Tried to find the correct regression range but mozregression could not point to the right push log url due to missing builds.
Best I could find is the following:

• Last good build: 2017-01-27 built from 8dbe8993536645eceeeaf8cb6fc53c03602d7c84
• First bad build: 2017-01-28 built from 045d8fe30f546ab08466c9586ce298e6459c2069b
• Push Log: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8dbe8993536645eceeeaf8cb6fc53c03602d7c84&tochange=045d8fe30f546ab08466c9586ce298e6459c2069