1576397 - Enabling message pane via hamburger button creates invalid message pane

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Eric Moore]

I'm using Thunderbird 68.0 (build id 20190816191614), with its own profile, under Windows 10. It initially had no message pane, displaying the welcome pane instead. I enabled the menu toolbar.

I enabled the message pane in Options -> Layout -> Message Pane using the hamburger button. That appears to create a message pane with no lines (zero height). It should have created a message pane with the same height as the welcome pane.

I looked at View -> Layout and it believes there is no message pane. If I drag and drop the bottom edge of the folder listing window upwards that creates a working message pane and updates View -> Layout in the toolbar to indicate there is one.

If I then drag and drop the top of the message pane to the bottom of the folder listing (zero line height) both View -> Layout and Options -> Layout in the hamburger button believes there is no message pane. If I drag and drop the bottom edge of the folder listing window upward to create a working message pane View -> Layout believes it exists but Options -> Layout in the hamburger button doesn't.

View -> Layout in the toolbar and Options -> Layout in the hamburger button are not working together correctly.

I did not have this problem using version 60.8 (with its own profile)

Comment 1

[Jorg K (CEST = GMT+2)]

Yes, there's something funny in the app menu related to the message pane. Even if there's no message pane, the item has a tick.

Paul, can you please take a look.

Comment 2

[Paul Morris [:pmorris]]

Attachment: show-message-pane-0.patch

Luckily it just took adding a single "!" character. Fixes updating the checked state of the appmenu > Preferences > Layout > Message Pane item. Flagging either jorgk or mkmelin for review.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9088250 [details] [diff] [review]
show-message-pane-0.patch

Now that it turns out that this is already broken in TB 60, I'm not interested any more, haha.

But honestly, thanks for fixing it!!

Comment 4

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/06505d8dff2521875d5ecd93d7ee931e8a479d66

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5e98fe41e475
Fix updating the checked state of "Message Pane" in appmenu. r=jorgk

Comment 6

[Jorg K (CEST = GMT+2)]

TB 69 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/c5cd0eb02cd0b582b19e0ef68532a6ab8ec19dcd