1576407 - Support returning OOP opener windows from Window.opener

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Kris Maglione [:kmag]]

This also implies removing nsGlobalWindowOuter::mOpener and getting the opener from the BrowsingContext instead.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1576407: Part 1 - Add HadOriginalOpener flag to BrowsingContext. r=farre

This is currently only available on the outer window, but needs to move to
BrowsingContext in order from us to remove redundant opener tracking from the
former.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1576407: Part 2 - Don't set BrowsingContext opener when forcing noopener. r=farre

We currently handler this correctly for the opener stored on the outer window,
but not on the BrowsingContext.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1576407: Part 3 - Return window opener as a WindowProxyHolder or BrowsingContext. r=farre

Also adds a legacy GetSameProcessOpener() method for callers which can only
deal with in-process windows and may need to be updated for Fission.

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1576407: Part 4 - Stop storing opener redundantly on nsGlobalWindowOuter. r=farre

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1576407: Part 5 - Update test expectations to handler cross-process window.opener being available. r=farre

This also sets the fission.rebuild_frameloaders_on_remoteness_change=true
preference for some mochitest directories which require it for cross-process
window.opener to work in top-level windows, and makes a minor change to the
hack in browser_temporary_permissions.js to keep it passing reliably in try
runs.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be7cbc61f825
Part 1 - Add HadOriginalOpener flag to BrowsingContext. r=farre
https://hg.mozilla.org/integration/autoland/rev/08d4c25fc670
Part 2 - Don't set BrowsingContext opener when forcing noopener. r=farre
https://hg.mozilla.org/integration/autoland/rev/0ddbc451dcab
Part 3 - Return window opener as a WindowProxyHolder or BrowsingContext. r=farre
https://hg.mozilla.org/integration/autoland/rev/19bf40067233
Part 4 - Stop storing opener redundantly on nsGlobalWindowOuter. r=farre
https://hg.mozilla.org/integration/autoland/rev/38e4ea431445
Part 5 - Update test expectations to handler cross-process window.opener being available. r=farre

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1576407: Follow-up: Ignore window.opener get/set when BrowsingContext is discarded. r=nika

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b0498064cbf
Follow-up: Ignore window.opener get/set when BrowsingContext is discarded.

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be74f006fdfd
Backed out 6 changesets for causing wpt and mochitest failures. CLOSED TREE

Comment 10

[Alexandru Michis [:malexandru]]

Backed out 6 changesets (Bug 1576407) for causing wpt and mochitest failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/be74f006fdfdbb07a3083b3ac4ba9f6547c3beb1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=be74f006fdfdbb07a3083b3ac4ba9f6547c3beb1&fromchange=38e4ea4314452422fe5fcfb8b1b557201ae9c0f8&selectedJob=263939366

Failure logs (before follow-up):

• At close-method.window.html & self-et-al.window.html:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263939093&repo=autoland&lineNumber=19024
• At opener-closed.html:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263946786&repo=autoland&lineNumber=3640
• At embedded-opener-remove-frame.html:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263937024&repo=autoland&lineNumber=6512
• At test_menubar.xul:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263941663&repo=autoland&lineNumber=25462

Failure logs (after follow-up):

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263959214&repo=autoland&lineNumber=25812

Comment 11

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5b86d2879a750e68921d9ff8b516ec526a4d5c5
Bug 1576407: Part 1 - Add HadOriginalOpener flag to BrowsingContext. r=farre

https://hg.mozilla.org/integration/mozilla-inbound/rev/97e495f0b3148162bb1ef3bee30656e6104ef390
Bug 1576407: Part 2 - Don't set BrowsingContext opener when forcing noopener. r=farre

https://hg.mozilla.org/integration/mozilla-inbound/rev/b64def9593e40d44971104547356ee7b44a76a44
Bug 1576407: Part 3 - Return window opener as a WindowProxyHolder or BrowsingContext. r=farre

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c55d3338a5b80e77b53ae3e3ed2f06f5331a438
Bug 1576407: Part 4 - Stop storing opener redundantly on nsGlobalWindowOuter. r=farre

https://hg.mozilla.org/integration/mozilla-inbound/rev/79e99efa822e3f6fc1fa483da4104f9211b62946
Bug 1576407: Part 5 - Update test expectations to handler cross-process window.opener being available. r=farre

https://hg.mozilla.org/integration/mozilla-inbound/rev/277b0a847f203afc93edd302f7ad1e9a4d14524c
Bug 1576407: Follow-up: Ignore window.opener get/set when BrowsingContext is discarded. r=nika

Comment 12

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e43b42cf9c65b318150af31c960faf91c35a816c
Bug 1576407: Follow-up: Move IsDiscarded check to BrowsingContext::GetOpener. r=nika

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e5b86d2879a7
https://hg.mozilla.org/mozilla-central/rev/97e495f0b314
https://hg.mozilla.org/mozilla-central/rev/b64def9593e4
https://hg.mozilla.org/mozilla-central/rev/7c55d3338a5b
https://hg.mozilla.org/mozilla-central/rev/79e99efa822e
https://hg.mozilla.org/mozilla-central/rev/277b0a847f20
https://hg.mozilla.org/mozilla-central/rev/e43b42cf9c65

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e5b86d2879a7
https://hg.mozilla.org/releases/mozilla-beta/rev/97e495f0b314
https://hg.mozilla.org/releases/mozilla-beta/rev/b64def9593e4
https://hg.mozilla.org/releases/mozilla-beta/rev/7c55d3338a5b
https://hg.mozilla.org/releases/mozilla-beta/rev/79e99efa822e
https://hg.mozilla.org/releases/mozilla-beta/rev/277b0a847f20
https://hg.mozilla.org/releases/mozilla-beta/rev/e43b42cf9c65