1576447 - "This time, search with:" string and cog icon duplicate after customization

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Itiel]

Attachment: Screenshot

Using Windows 10, latest Nightly.

STR:

1. Toggle browser.urlbar.megabar to true and change intl.uidirection to 1
2. Restart Nightly
3. Type anything in the megabar

AR:
The "This time, search with:" string and cog icon appear twice.
See attached.

ER:
Both should appear once.

Comment 1

[Harry Twyford [:harry]]

Itiel, I encountered an issue like this on Mac in a LTR locale but it was fixed in the batch of Megabar layout fixes that landed in the past few days. I followed your STR and wasn't able to replicate this bug (albeit on Mac).

Using a Nightly from August 27 or later, are you still able to reproduce this issue?

Comment 2

[Itiel]

(In reply to Harry Twyford [:harry] from comment #1)

Itiel, I encountered an issue like this on Mac in a LTR locale but it was fixed in the batch of Megabar layout fixes that landed in the past few days. I followed your STR and wasn't able to replicate this bug (albeit on Mac).

Using a Nightly from August 27 or later, are you still able to reproduce this issue?

I think this is not reproducible anymore, will check tomorrow.
Keeping ni? to remind me.

Comment 3

[Itiel]

Yep, not an issue anymore.

Comment 4

[Dão Gottwald [::dao]]

I see this in today's nightly (en-US build).

Comment 5

[Dão Gottwald [::dao]]

It's not a rendering issue, the elements are actually duplicated in the DOM. Presumably a bug in search-one-offs.js or related urlbar code.

Comment 6

[Harry Twyford [:harry]]

To reproduce, open customize view, exit it, and then type in the Urlbar. A header string + cog icon will appear for each time you do this.

I reverted to the patch from bug 1561894 and this issue did not exist then, so it's something that's been introduced since. This also happens both with and without megabar enabled.

Comment 7

[Dão Gottwald [::dao]]

I think bug 1561533 probably regressed this.

Comment 8

[Harry Twyford [:harry]]

Exiting customize mode calls UrlbarInput.uninit(). We used to remove the panel on uninit and then re-add it on re-initialization which would give us a fresh copy of the search one offs container. Since we no longer do this, copies of the search one offs keep piling up. Working on verifying this now.

Comment 9

[Harry Twyford [:harry]]

Attachment: Bug 1576447 - Stop duplicating one-offs container on UrlbarInput uninit. r?dao

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e5ac5ef3c9a
Stop duplicating one-offs container on UrlbarInput uninit. r=dao

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3e5ac5ef3c9a

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3e5ac5ef3c9a

Comment 13

[Anca Soncutean [:Anca], Desktop Release QA]

I’ve reproduced this issue with Fx 70.0a1 (2019-08-25) on Windows 10 x64.
The issue is fixed with Fx 71.0a1 (2019-09-23) and Fx 70.0b8 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64.