1576549 - mozilla::a11y::ProxyAccessible::Bounds is slow on GeckoView when clicking date field on hotels.com

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Makoto Kato [:m_kato]]

https://perfht.ml/33Xkwrf

When clicking date field on hotels.com, mozilla::a11y::ProxyAccessible::Bounds (to update viewport cache) spends a lot of times because SendExtents is sync IPC.

Could you change this to async IPC?

Comment 1

[Denis Palmeiro [:denispal]]

Hi Makoto,

What device did you experience this on?

Thanks!

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Denis Palmeiro [:denispal] from comment #1)

Hi Makoto,

What device did you experience this on?

Thanks!

Pixel2 and XPERIA XZ2 compact. I think that issue occurs on all devices. I guess that this issue is that a11y tries to update view port cache per animation. So profiler shows that a lot of sync calls by a11y.

Original case is bug 1517635. When turning off a11y via accessibility.force_disabled=1, bug 1517635's test case becomes smooth.

Comment 3

[Chris Peterson [:cpeterson]]

Removing the [geckoview] whiteboard tag because this a11y perf problem is probably not in GeckoView code.

Comment 4

[Eitan Isaacson [:eeejay]]

We have a special async Batch message that is supposed to make us avoid sync IPC calls, looks like I overlooked the bounds data we receive and still make a sync call. oops!

Easy fix.

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1576549 - Use bounds in bundle argument instead of getter method. r?Jamie!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59b97cbfadda
Use bounds in bundle argument instead of getter method. r=Jamie

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/59b97cbfadda

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/59b97cbfadda