Middle clicking multiple selected tabs closes only the clicked tab
Categories
(Firefox :: Tabbed Browser, defect, P5)
Tracking
()
People
(Reporter: vlucaci, Assigned: niklas)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-quality-foundation])
Attachments
(2 files)
Affected versions
- 69.0b16
- 70.0a1 (2019-08-25)
- 68.0.2
Affected platforms
- Windows 10x64
- macOS 10.14.6
- Ubuntu 18.04x64
Steps to reproduce
- Launch FF.
- Access a few sites(each one in a new tab) of your choosing.
- Select several (or all) of them via CTRL+Click or Shift+Click.
- Middle mouse click one of the selected tabs.
Expected result
- The selection of tabs closes when the user middle clicks one of the tabs
Actual result
- The selected tabs are not closed, besides only the tab on which the user has performed the middle click.
Regression range
- Will return with regression ASAP.
Comment 2•5 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
Hello,
This issue does not seem to be a regression. I want as far back as 2018-08-29, about the same time when Multi-Select Tabs was being implemented and the issue occurs there with the same repro steps.
It seems that this (middle click) action was not defined to close the selection of tabs ever since then.
However this would be a great quality of life improvement, as the user would have another method of closing multiple selected tabs.
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Please consider this use case before implementing a fix for this bug:
Many tabs selected
Accidentally middle-clicked one of the selected tabs instead of right-clicking (happens occasionally on laptop trackpad with click zones set)
Result - many tabs get closed
Recovery Options - 'Undo Close Tab' many times (as it only reopens one at a time) or retrieve them all out of History
Could we get a fix for Bug 887515 (i.e. Bug 1487193 ) or a pref to turn off 'middle-click closes tabs' before/when fixing this bug?
Comment 5•3 years ago
|
||
Updated•2 years ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Updated•11 months ago
|
Assignee | ||
Comment 6•11 months ago
|
||
Assignee | ||
Comment 7•11 months ago
|
||
This is no longer blocked now that bug 887515 has been implemented.
Clicking the close button on a multiselected tab closes all multiselected tabs so we should match the behavior defined here for middle clicking a multiselected tab.
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2814e09f635a Close all multiselected tabs on middle click. r=dao
Comment 9•11 months ago
|
||
Backed out for causing failures on browser_multiselect_tabs_close.js
- backout: https://hg.mozilla.org/integration/autoland/rev/fa92d5e9815e17a26769fbf23c91bcad13890c0b
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=2814e09f635a0c47aadae8c3cb5ac25f11fc2559
- tier 1 failure: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=CMd8bWlyRX2PvTq2N9my2w.0&revision=8c7b252056dcc8cb3f22b58ff01cc15eedfcea72&searchStr=os%2Cx%2C10.15%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-macosx1015-64-qr%2Fdebug-mochitest-browser-chrome-spi-nw%2Cbc5
- failure log: https://treeherder.mozilla.org/logviewer?job_id=415971861&repo=autoland&lineNumber=7283
[task 2023-05-16T16:05:51.453Z] 16:05:51 INFO - TEST-PASS | browser/base/content/test/tabs/browser_multiselect_tabs_close.js | Zero multiselected tabs -
[task 2023-05-16T16:05:51.454Z] 16:05:51 INFO - Buffered messages finished
[task 2023-05-16T16:05:51.454Z] 16:05:51 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_close.js | Test timed out -
[task 2023-05-16T16:05:51.455Z] 16:05:51 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-05-16T16:05:51.455Z] 16:05:51 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_close.js | Uncaught exception received from previously timed out test bound closeAllMultiselectedMiddleClick - TabClose listener not removed before the end of test
[task 2023-05-16T16:05:51.456Z] 16:05:51 INFO - GECKO(1387) | MEMORY STAT | vsize 8230MB | residentFast 495MB | heapAllocated 163MB
[task 2023-05-16T16:05:51.456Z] 16:05:51 INFO - TEST-OK | browser/base/content/test/tabs/browser_multiselect_tabs_close.js | took 90059ms
[task 2023-05-16T16:05:51.456Z] 16:05:51 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-05-16T16:05:51.457Z] 16:05:51 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_close.js | Found a tab after previous test timed out: http://mochi.test:8888/ -
[task 2023-05-16T16:05:51.457Z] 16:05:51 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-05-16T16:05:51.458Z] 16:05:51 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_close.js | Found a tab after previous test timed out: http://mochi.test:8888/ -
[task 2023-05-16T16:05:51.458Z] 16:05:51 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-05-16T16:05:51.458Z] 16:05:51 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_close.js | Found a tab after previous test timed out: http://mochi.test:8888/ -
[task 2023-05-16T16:05:51.459Z] 16:05:51 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-05-16T16:05:51.459Z] 16:05:51 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_close.js | terminating browser early - unable to close tabs; skipping remaining tests in folder -
[task 2023-05-16T16:05:51.460Z] 16:05:51 INFO - GECKO(1387) | Completed ShutdownLeaks collections in process 1387
Comment 10•11 months ago
|
||
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/969dde8601ec Close all multiselected tabs on middle click. r=dao
Comment 11•11 months ago
|
||
bugherder |
Updated•11 months ago
|
Updated•11 months ago
|
Comment 12•10 months ago
|
||
Verified as fixed with Windows 10x64, macOS 10.12.6 and Ubuntu 18.4 Firefox 116.0a1 and Firefox 115.0b3.
Updated•10 months ago
|
Description
•