Closed Bug 1576614 Opened 1 year ago Closed 1 year ago

Port |Bug 1452361 - Don't reset to default permissions for cookies in page info| to SeaMonkey

Categories

(SeaMonkey :: Page Info, defect)

defect
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.68
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Port the following:

  • Bug 1452361 - Don't reset to default permissions for cookies in page info
Attached patch Cookie defaults (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): unsure
User impact if declined: Resetting cookie permissions do not work correctly
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Attachment #9088128 - Flags: review?(frgrahl)
Attachment #9088128 - Flags: approval-comm-release?
Attachment #9088128 - Flags: approval-comm-esr60?

Unbitrot following update to Bug 1574689

Attachment #9088128 - Attachment is obsolete: true
Attachment #9088128 - Flags: review?(frgrahl)
Attachment #9088128 - Flags: approval-comm-release?
Attachment #9088128 - Flags: approval-comm-esr60?
Attachment #9088324 - Flags: review?(frgrahl)
Attachment #9088324 - Flags: approval-comm-release?
Attachment #9088324 - Flags: approval-comm-esr60?
Comment on attachment 9088324 [details] [diff] [review]
Cookie defaults v1.1

If you uncheck default "Always" will always be pre-checked in the cookies radio group even if you have "For current Session" only checked in prefs. Is this expected?

r/a+ with question answered.
Attachment #9088324 - Flags: review?(frgrahl)
Attachment #9088324 - Flags: review+
Attachment #9088324 - Flags: approval-comm-release?
Attachment #9088324 - Flags: approval-comm-release+
Attachment #9088324 - Flags: approval-comm-esr60?
Attachment #9088324 - Flags: approval-comm-esr60+

Does this behave better for you?
I could have left the first hunk of permissions.js alone and only change the hunk in onRadioClick

Attachment #9097211 - Flags: feedback?(frgrahl)

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/57752d5ccb81
Port Bug 1452361 "Don't reset to default permissions for cookies in page info" to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Comment on attachment 9097211 [details] [diff] [review]
Cookie defaults v1.2

I had some problems with the patch. Checking an unchecking the default needs to be done 2 times to produce a result. 
When inactive the radio button is checked which I think is wrong (if I understand the FX bug correctly). 

Lets do further changes in with a follow-up part 2 or new bug.
Attachment #9097211 - Flags: feedback?(frgrahl) → feedback-
You need to log in before you can comment on or make changes to this bug.