Closed
Bug 1576697
Opened 5 years ago
Closed 5 years ago
Introduce LauncherResult in WinHeaderOnlyUtils.h instead of WindowsErrorResult
Categories
(Firefox :: Launcher Process, task)
Firefox
Launcher Process
Tracking
()
RESOLVED
FIXED
Firefox 71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: toshi, Assigned: toshi)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently the functions in WinHeaderOnlyUtils.h use WindowsErrorResult to handle an error. For fine-grained error analysis, we can use LauncherResult because it saves a filename and a line number.
It will be useful especially to analyze the launcher result failures.
|
Assignee | |
Updated•5 years ago
|
Component: Widget: Win32 → Launcher Process
Product: Core → Firefox
|
|
Assignee | |
Comment 1•5 years ago
|
||
WindowsErrorResult is a class to hold either a value or a Windows error
code based on the Result template. We also have LauncherResult for the
same purpose, which was introduced as a part of the launcher process feature
afterward. The difference is LauncherResult holds a filename and line
number along with an error code.
This patch integrates LauncherResult.h into WinHeaderOnlyUtils.h so that we
can use LauncherResult more broadly.
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7a3378adb340 Use LauncherResult in WinHeaderOnlyUtils.h instead of WindowsErrorResult. r=aklotz
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•