make symbolstore.py complain loudly if expected output isn't found
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox81 fixed)
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
Assignee | ||
Comment 1•5 years ago
|
||
This change surfaces errors faster, and ensures that we don't silently
end up with empty crashreporter symbols if dump_syms
can't run for
some reason.
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5c3925fab83 make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Comment 3•5 years ago
|
||
Backed out changeset f5c3925fab83 (Bug 1576748) for bustage in symbolstore.py
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263698608&repo=autoland&lineNumber=36981
Backout: https://hg.mozilla.org/integration/autoland/rev/1630fa8aa729c0c3689d7f42905ddaf1b10682aa
Assignee | ||
Comment 4•5 years ago
|
||
Oh, good, debug OS X says:
dump_syms: /builds/worker/workspace/build/src/toolkit/crashreporter/google-breakpad/src/common/mac/dump_syms.cc:443: bool google_breakpad::DumpSymbols::ReadDwarf(google_breakpad::Module *, const mach_o::Reader &, const mach_o::SectionMap &, bool) const: Assertion `debug_info_entry != file_context.section_map().end()' failed.
Frighteningly, shippable OS X failed in the same way. Well, with a segfault rather than an assertion failure. Doubly frighteningly, shippable OS X builds on central actually produce symbols...which leads one to wonder what exactly those symbols correspond to...
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d271586649f make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Comment 6•5 years ago
|
||
Backed out changeset 9d271586649f (bug 1576748) for spidermonkey bustages.
Backout: https://hg.mozilla.org/integration/autoland/rev/0cd5f3db57e8b1b3be23936b8d0bd7b86689b871
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=264261048&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=9d271586649f004ee40ce35fbe510c567d54c1f0
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264261048&repo=autoland&lineNumber=6731
Assignee | ||
Comment 7•5 years ago
|
||
Great, another build that has been trying to dump symbols and been silently failing at doing so.
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/97ec7ec089c4 make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Comment 9•5 years ago
|
||
bugherder |
Comment 10•5 years ago
|
||
Backed out changeset 97ec7ec089c4 (Bug 1576748) for bustage in symbolstore.py
First bustage appeared on central:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception&revision=8867e44d49793d8af6b514089cf4b5ebea446985&selectedJob=264449591&searchStr=23b18af6a59f49cd2c5e7323b5550bfa9ea13eb5
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264455052&repo=autoland&lineNumber=37884
Backout: https://hg.mozilla.org/integration/autoland/rev/10f791c3a57f54869b1afeb237dbc544f74f4591
Comment 12•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:froydnj, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 14•4 years ago
|
||
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92fa0186cb81 make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Assignee | ||
Updated•4 years ago
|
Comment 15•4 years ago
|
||
Backed out changeset 92fa0186cb81 (bug 1576748) for build bustage on symbolstore.py CLOSED TREE
Backout revision https://hg.mozilla.org/integration/autoland/rev/b6760b4f2190c4569ac89e8a7369833bcb85f172
Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=278016904&repo=autoland
Nathan can you please take a look?
Assignee | ||
Updated•4 years ago
|
Comment 16•4 years ago
|
||
FWIW, I hit this on my first attempt at dumping symbols on windows-cross builds, where the tasks would go green but the symbols archives would be empty.
Assignee | ||
Comment 17•4 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #16)
FWIW, I hit this on my first attempt at dumping symbols on windows-cross builds, where the tasks would go green but the symbols archives would be empty.
Last time I tried pushing this, I hit even more weird OS X errors than the original errors this patch was trying to fix. I will make some time to look at this next week, does that work for you?
Comment 18•4 years ago
|
||
Oh it's not blocking me, obviously. I just was about to file a new bug about this issue because I was surprised my symbols archives were empty without the build system saying a word and found this one.
Updated•4 years ago
|
Comment 19•4 years ago
|
||
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8150e3490a27 make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Comment 20•4 years ago
|
||
bugherder |
Description
•