Closed Bug 1576748 Opened 5 years ago Closed 4 years ago

make symbolstore.py complain loudly if expected output isn't found

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

No description provided.

This change surfaces errors faster, and ensures that we don't silently
end up with empty crashreporter symbols if dump_syms can't run for
some reason.

Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5c3925fab83
make symbolstore.py complain loudly if expected output isn't found; r=nalexander

Oh, good, debug OS X says:

dump_syms: /builds/worker/workspace/build/src/toolkit/crashreporter/google-breakpad/src/common/mac/dump_syms.cc:443: bool google_breakpad::DumpSymbols::ReadDwarf(google_breakpad::Module *, const mach_o::Reader &, const mach_o::SectionMap &, bool) const: Assertion `debug_info_entry != file_context.section_map().end()' failed.

Frighteningly, shippable OS X failed in the same way. Well, with a segfault rather than an assertion failure. Doubly frighteningly, shippable OS X builds on central actually produce symbols...which leads one to wonder what exactly those symbols correspond to...

Flags: needinfo?(nfroyd)
Depends on: 1576941
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d271586649f
make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Depends on: 1577812

Great, another build that has been trying to dump symbols and been silently failing at doing so.

Flags: needinfo?(nfroyd)
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97ec7ec089c4
make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1578090
Depends on: 1578531

Sigh, central-only jobs.

Flags: needinfo?(nfroyd)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:froydnj, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(nfroyd)
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92fa0186cb81
make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Flags: needinfo?(nfroyd)
Flags: needinfo?(nfroyd)

FWIW, I hit this on my first attempt at dumping symbols on windows-cross builds, where the tasks would go green but the symbols archives would be empty.

(In reply to Mike Hommey [:glandium] from comment #16)

FWIW, I hit this on my first attempt at dumping symbols on windows-cross builds, where the tasks would go green but the symbols archives would be empty.

Last time I tried pushing this, I hit even more weird OS X errors than the original errors this patch was trying to fix. I will make some time to look at this next week, does that work for you?

Flags: needinfo?(mh+mozilla)

Oh it's not blocking me, obviously. I just was about to file a new bug about this issue because I was surprised my symbols archives were empty without the build system saying a word and found this one.

Flags: needinfo?(mh+mozilla)
Depends on: 1652865
Attachment #9088273 - Attachment description: Bug 1576748 - make symbolstore.py complain loudly if expected output isn't found; r=#build → Bug 1576748 - make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8150e3490a27
make symbolstore.py complain loudly if expected output isn't found; r=nalexander
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: