Closed Bug 1576833 Opened 3 months ago Closed 3 months ago

Metadata update doesn't handle tests with a / in the query or fragment

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: jgraham, Assigned: jgraham)

Details

Attachments

(1 file)

Because we just do rsplit("/"), so end up splitting off the end of the query rather than the path after the last / + query + fragement.

For tests with ids like foo/bar?baz/foobar we were incorrectly setting the manifest test_id
to foobar rather than bar?baz/foobar. Fix this by determining the length of the path up to
the last / and trimming that off the front of the test id. This approach avoids
reserializing the url.

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/493b216296d5
Handle tests with / in the path in metadata update, r=dheiberg
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18692 for changes under testing/web-platform/tests
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Upstream PR was closed without merging
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.