1576844 - Error message when closing multi-proxy Browser Console

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Sometimes, when closing the Browser Console (no clear STR), there's the following error in the terminal:

Handler function LocalDebuggerTransport instance's this.other.hooks.onPacket threw an exception: Error: Unexpected packet server1.conn0.content-process27/contentProcessTarget1, {"from":"server1.conn0.content-process27/contentProcessTarget1","type":"tabDetached"}

I think the packet is sent from devtools/server/connectors/content-process-connector.js#106 but can't be handled on the client-side because the content-process front doesn't have the tabDetached event declared, see devtools/shared/specs/targets/content-process.js (we have it for the browser context though devtools/shared/specs/targets/browsing-context.js#135)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1576844 - Add a tabDetached even in content-process spec. r=yulia.

This event is sent from the content-process-connector in the server,
and not having it declared in the spec was causing unknown packets
error messages.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a49a4f522714
Add a tabDetached even in content-process spec. r=yulia.

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a49a4f522714