1576899 - Set output argument in `nsIContentSerializer::Init` instead of passing it to `nsIContentSerializer::Append*`

Status: RESOLVED FIXED

(Core :: DOM: Serializers, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1576899: change `nsIContentSerializer` to take output string as argument in `nsIContentSerializer::Init`. r=hsivonen

Before, all nsIContentSerializer::Append* methods took an output
string. The state of nsPlainTextSerializer depended on the string
pointing to the same object.

Now, it's ensured that the same output string is used between
nsIContentSerializer::Init and nsIContentSerializer::Finish.

Moreover, nsHTMLCopyEncoder::EncodeToStringWithContext re-used
mSerializer without initializing it again. This was error-prone,
because after serializing with mSerializer, it's internal state might
have changed to an undesirable one (e.g.
nsPlainTextSerializer::mWrapColumn could've been modified).
Hence, it is now initialized again before serializing the common
ancestors.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10716060af24
change `nsIContentSerializer` to take output string as argument in `nsIContentSerializer::Init`. r=hsivonen

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/10716060af24