1576906 - Perma wpt TEST-UNEXPECTED-FAIL | /css/css-inline/parsing/line-height-computed.html | Property line-height value 'normal' computes to 'normal' - assert_equals: expected "normal" but got "48px" when Gecko 70 merges to Beta on 2019-08-26

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cosmin Sabou [:CosminS]]

[Tracking Requested - why for this release]:
Central as late beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=2cb247c090676098e245888ea8dca0899f693357&searchStr=wpt4&selectedJob=263680022

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=263680022&repo=try

[task 2019-08-27T12:38:06.354Z] 12:38:06 INFO - TEST-START | /css/css-inline/parsing/line-height-computed.html
[task 2019-08-27T12:38:06.637Z] 12:38:06 INFO - Closing window 41
[task 2019-08-27T12:38:06.936Z] 12:38:06 INFO -
[task 2019-08-27T12:38:06.936Z] 12:38:06 INFO - TEST-UNEXPECTED-FAIL | /css/css-inline/parsing/line-height-computed.html | Property line-height value 'normal' computes to 'normal' - assert_equals: expected "normal" but got "48px"
[task 2019-08-27T12:38:06.936Z] 12:38:06 INFO - test_computed_value/<@http://web-platform.test:8000/css/support/computed-testcommon.js:31:20
[task 2019-08-27T12:38:06.936Z] 12:38:06 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1611:25
[task 2019-08-27T12:38:06.936Z] 12:38:06 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:30
[task 2019-08-27T12:38:06.936Z] 12:38:06 INFO - test_computed_value@http://web-platform.test:8000/css/support/computed-testcommon.js:21:7
[task 2019-08-27T12:38:06.936Z] 12:38:06 INFO - @http://web-platform.test:8000/css/css-inline/parsing/line-height-computed.html:22:20
[task 2019-08-27T12:38:06.937Z] 12:38:06 INFO - .........
[task 2019-08-27T12:38:06.937Z] 12:38:06 INFO - TEST-OK | /css/css-inline/parsing/line-height-computed.html | took 583ms

Aryx pointed this out: https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#4890
should be fixed by a line like that https://searchfox.org/mozilla-central/source/testing/web-platform/meta/css/cssom/getComputedStyle-line-height.html.ini#2

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1576906 - Turn on layout.css.line-height.normal-as-resolved-value.enabled in line-height-computed.html. r=emilio

By default, it is only enabled in Nightly and Early Beta and causes the test to fail on Late Beta.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22443bed5485
Turn on layout.css.line-height.normal-as-resolved-value.enabled in line-height-computed.html. r=emilio

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/22443bed5485

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 5

[Cosmin Sabou [:CosminS]]

Verified fixed in today's beta-sims: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=9903e7193b3c0e4cf5cc815a1ec0024350919df9&searchStr=wpt4&group_state=expanded&selectedJob=264038568