1576907 - Don't add expressions to history in private mode

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P2)

Description

[Ashutosh Sharma]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. Open web console (in private window)
2. Try anything in the console and close browser window
3. Re-open browser and web console

Actual results:

Earlier expression/string can be found in history

Expected results:

History should not be kept at least when using private window. Actually it would be nice to have a preference whether to save history or not.

Comment 1

[Ashutosh Sharma]

Right now I have set devtools.webconsole.inputHistoryCount to 0 to entirely disable it

Comment 2

[Timea Cernea [:tbabos][inactive]]

Hi Ashutosh Sharma,

Thanks for the filed issue, the console commands are indeed saved and shown in history from private browsing windows too.
Will mark this as an enhancement and move it over to a component so the developers can take a look at it.

Comment 3

[:Harald Kirschner :digitarald]

Given how some development happens in private browsing, for private or other reasons, retaining any of this information is not good.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

This is where we store the expressions /devtools/client/webconsole/middleware/history-persistence.js#45-57
Before setting them, we should check if we're in private mode .

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1576907 - [devtools] Don't add expressions from private window console in history. r=bomsy.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39d5dc270aa9
[devtools] Don't add expressions from private window console in history. r=bomsy.

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/39d5dc270aa9