157692 - Should replace <label>s with <label for="">s

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Jouni Heikniemi]

We should change the templates using containing <label> syntax
(<label><element>text</label>) to use the indirect idref syntax (<label
for="someid">text</label><input id="someid" ...>, since Windows IE's up to
version 5.5 do not implement the containing syntax version properly (the labels
are not clickable). 

There aren't too many instances of this yet, so it should be an easy fix.

Comment 1

[Tobias Burnus]

Attachment: Remove <label> in favour of <label for="">

This occured actually only once.

Comment 2

[Tobias Burnus]

Comment on attachment 92934 [details] [diff] [review]
Remove <label> in favour of <label for="">

There is a bug in this patch (extra </label>).

This is fixed in the attachment to bug 157573.

Comment 3

[Dave Miller [:justdave]]

The User Interface component now belongs to Gerv.  Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.

Comment 4

[Dave Miller [:justdave]]

Reassigning back to Myk.  That stuff about Gerv taking over the User Interface
component turned out to be short-lived.  Please pardon our confusion, and I'm
very sorry about the spam.

Comment 5

[Anne (:annevk)]

Attachment: patch #1

If this is r=myk, could you check it in as well? Thanks.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 172902 [details] [diff] [review]
patch #1

Looks good, works well. r=myk

Nit: this would've been a good time to remove the control from within the label
tag, simplifying layout by making it less hierarchical, but it's not a big
deal.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.52; previous revision: 1.51
done