Closed Bug 1576936 Opened 4 years ago Closed 4 years ago

Perma devedition performance/browser_windowopen.js failure - unexpected changed rect for 70 going to beta

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox68 unaffected, firefox69 unaffected, firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1576936 - fix browser_windowopen for devtools button having moved, r?jaws
47 bytes, text/x-phabricator-request
Details | Review

Trypush:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac997a15f7b2a2fa878e6b9d8e601bdb3f2c5b60&selectedJob=263704278

The offending code is at https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/base/content/test/performance/browser_windowopen.js#86-91 . Now that the devtools button is further to the right, the reload button no longer shifts. Just getting rid of the ternary there will shut this back up again.

Type: task → defect
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/06a3816a2a49
fix browser_windowopen for devtools button having moved, r=jaws

https://hg.mozilla.org/mozilla-central/rev/06a3816a2a49

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.