Closed Bug 1576949 Opened 1 year ago Closed 1 year ago

Clicking the Run button with selected text in the input should only evaluate the selected text

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(firefox70 verified)

VERIFIED FIXED
Firefox 70
Tracking Status
firefox70 --- verified

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

Steps to reproduce

  1. Open the webconsole
  2. Switch to editor mode
  3. In the input, paste
var x = 10; x;
x = 20; x;
  1. Select the first line in the input (var x = 10; x;)
  2. Hit the Run button

Expected results

Only the selected line is evaluated

Actual results

The whole input is evaluated

This is done by modifying the evaluateExpression action,
where we retrieve the selection of the full input.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9a04ff4a68a
Clicking the Editor Run button when input has text selection only evaluate selected text. r=Honza.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → nchevobbe
Flags: qe-verify+

Confirmed issue with 70.0a1 (2019-08-27) on Windows 10.
Verified fix with 70.0b7 on Windows 10, macOS 10.13, Ubuntu 16.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.