1576950 - Panel for applications for incoming attachment shows up empty after startup (TB 68)

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1576825 +++

When we use "handler.json (bad)" from bug 1576825 attachment 9088366 [details] the list of incoming attachment types and actions looks empty and acts erratically when sorted.

See bug 1576825 comment #21 for details.

Comment 1

[Jorg K (CEST = GMT+2)]

OK, with the bad file, we get this on trunk:

TypeError: this.mBundle is undefined general.js:2109:7
get typeDescription chrome://messenger/content/preferences/general.js:2109
sortByType chrome://messenger/content/preferences/general.js:1667
comparefn self-hosted:251
InsertionSort self-hosted:3658
MergeSort self-hosted:3723
sort self-hosted:254
_sortVisibleTypes chrome://messenger/content/preferences/general.js:1678
_delayedPaneLoad chrome://messenger/content/preferences/general.js:253

All this comes from bug 1460392 and there we read in bug 1460392 comment #4: The FX part 3 is stringbundle changes we don't need to port.
So we didn't port this:
https://hg.mozilla.org/mozilla-central/rev/d3afbfe98a71

Maybe there's a problem. Looks like the two type that upset it are TB specific, bug 1576825 comment #14: text/rfc822-headers and application/ics.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1576950-fix-disambiguate.patch

This shows that the console really spits out the right location.

Something goes wrong in disambiguation. With this hack, the list is properly displayed.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1576950-fix-disambiguate.patch

This fixes it. Wrong this.

Comment 4

[:aceman]

Comment on attachment 9088545 [details] [diff] [review]
1576950-fix-disambiguate.patch

Review of attachment 9088545 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice, thank you!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3f23a0fb3500
fix incoming attachment list if disambiguation is necessary. r=aceman

Comment 6

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/c174faf78f3c61b0b86fc2b1cc27d688da90a592