Closed Bug 1576968 Opened 3 months ago Closed 3 months ago

Do not call flushBuffer when rendering offscreen

Categories

(Core :: Graphics: Layers, task)

All
macOS
task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

See bug 1576767 comment 5:

We call [glContext flushBuffer] on an NSOpenGLContext that is not attached to an NSView and that only renders into (non-0) framebuffers. On pre-10.15, this seems to be handled as just a glFlush(), but maybe it confuses 10.15. We can just call glFlush() instead.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/28ed211ab542
Use glFlush() instead of -[NSOpenGLContext flushBuffer] when we have no framebuffer zero. r=mattwoodrow
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

It appears that this has fixed my crash as reported in bug 1576767. Since installing a build mstange sent me yesterday afternoon, I haven't crashed once, whereas I'd crashed 6 times on the 26th, 3 times on the 27th, and twice on the 28th -- and that's despite the fact that I'd been doing nearly all my work in Safari instead of Firefox to avoid the crashes. I've switched back to Firefox full-time since 4 PM EDT yesterday and it hasn't crashed once yet.

That's great news! This patch is in Nightly now so you can stop using my build and use regular Nightly again.

You need to log in before you can comment on or make changes to this bug.