Do not call flushBuffer when rendering offscreen
Categories
(Core :: Graphics: Layers, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
Details
Attachments
(1 file)
We call
[glContext flushBuffer]
on anNSOpenGLContext
that is not attached to anNSView
and that only renders into (non-0) framebuffers. On pre-10.15, this seems to be handled as just a glFlush(), but maybe it confuses 10.15. We can just call glFlush() instead.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/28ed211ab542 Use glFlush() instead of -[NSOpenGLContext flushBuffer] when we have no framebuffer zero. r=mattwoodrow
Comment 3•5 years ago
|
||
bugherder |
Comment 4•5 years ago
|
||
It appears that this has fixed my crash as reported in bug 1576767. Since installing a build mstange sent me yesterday afternoon, I haven't crashed once, whereas I'd crashed 6 times on the 26th, 3 times on the 27th, and twice on the 28th -- and that's despite the fact that I'd been doing nearly all my work in Safari instead of Firefox to avoid the crashes. I've switched back to Firefox full-time since 4 PM EDT yesterday and it hasn't crashed once yet.
Assignee | ||
Comment 5•5 years ago
|
||
That's great news! This patch is in Nightly now so you can stop using my build and use regular Nightly again.
Description
•