1577007 - Add debugger method to compare underlying natives

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Brian Hackett [Laid off!]]

In order for the devtools to properly implement a whitelist of the native functions which can be called when doing eager evaluations, there needs to be a way to determine the actual native function which is being invoked when we are in the Debugger.onNativeCall hook. The name properties of the function object aren't a very robust way of checking this, but one straightforward way is to compare the object with functions from the devtools code's own realm, e.g. object.isSameNative(Array.prototype.push).

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1577007 - Add debugger method to compare underlying natives, r=jimb.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b4ecd73e277
Add debugger method to compare underlying natives, r=jimb.

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/4b4ecd73e277

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for conflicting with the backout of Bug 1576776

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4048af298d81
Backed out 5 changesets (bug 1577007, bug 1576776, bug 1576781, bug 1564167) for crashtest failures

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0598d793b1ff
Add debugger method to compare underlying natives, r=jimb.

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for SM bustages on eqArrayHelper.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/fd6ff5c5f1bfbdbb69d540cec22478a705b1709d
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265733893&repo=autoland&lineNumber=23635

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed4a29cb6aed
Add debugger method to compare underlying natives, r=jimb.

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ed4a29cb6aed