1577021 - Add gtest coverage for non-ascii codecs in MimeTypes

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Bug 1573381 shows a lack of coverage in our tests for working with MimeType strings. Specifically that when calculating if a string is a prefix of a codec in a mime type we were not correctly checking that prefix.

We could cover that bug, as well as improve coverage by having tests that check against non-ascii MimeTypes.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1577021: Add test coverage for non-ascii characters in MimeType codecs. r?dminor

Provides coverage for an issue fixed in 1573381. Note that while that bug
discusses big endian machines, the tests added will cover both the big and
little endian case of the bug. This is because we have test cases that make sure
both octets of 16 wide char are being correctly compared.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81bb1eaa1c0b
Add test coverage for non-ascii characters in MimeType codecs. r=dminor

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 81bb1eaa1c0b (Bug 1577021) for causing build bustages in TestMediaMIMETypes.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=81bb1eaa1c0b4caf0cbf0fb832a3f98b2d2a34aa&selectedJob=264791750

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264791750&repo=autoland&lineNumber=26027

Backout: https://hg.mozilla.org/integration/autoland/rev/056edede04886f740abed5c2f3428615b6992498

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Figured using a u8 prefix would be more specific and thus preferred, but seems not. Let's try that again.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be35733bd975
Add test coverage for non-ascii characters in MimeType codecs. r=dminor

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/be35733bd975

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/0de77a37470a

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/49465f2303ae