Closed Bug 1577074 Opened 1 year ago Closed 11 months ago

Instrument scripts executed from editor mode

Categories

(DevTools :: Console, task, P1)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: Harald, Assigned: nchevobbe)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Simplest fix would probably adding an extra_key to the execute_js event: https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Events.yaml#1065. The key would be input and the value either be inline or multiline.

Later we can think about more user flows, but users actually executing code in editor mode is the success metric should probably track most right now.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

We add an extra "input" property that is filled with
either "inline" or "multiline" depending if the expression
was evaluated in regular webconsole layout or in editor mode.

The test that was checking the execute_js telemetry event is
modify to only check what it was created for (hitting enter
on incomplete expression adds new line), and a new test is
added to specifically check that the execute_js telemetry event
is recorded as we expect.

Attached file request.txt
Attachment #9088883 - Flags: data-review?(tdsmith)
Priority: -- → P1
Blocks: 1576568
Comment on attachment 9088883 [details]
request.txt

Changing data steward as Tim is out today.
Attachment #9088883 - Flags: data-review?(tdsmith) → data-review?(bmiroglio)
Comment on attachment 9088883 [details]
request.txt

# Data Review Form 

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

This will be documented in the Events specification: https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Events.yaml

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, this can be turned off by toggling off Telemetry in Preferences

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

:digitarald

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2: Interaction Data

5) Is the data collection request for default-on or default-off?

default-on

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No, this data is permanent.

9) Does the data collection use a third-party collection tool? **If yes, escalate to legal.**

No.

data-review r+
Attachment #9088883 - Flags: data-review?(bmiroglio) → data-review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e9f2e7ef819
Instrument scripts executed from editor mode. r=rcaliman.
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Target Milestone: Firefox 70 → Firefox 71
You need to log in before you can comment on or make changes to this bug.