Closed Bug 1577102 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18720 - [LayoutNG] Fixes positions/sizes of empty inline boxes

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18720 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18720
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fixes positions/sizes of empty inline boxes

This patch sets to create a box fragment (not to cull) empty
inline boxes.

|NGInlineBoxState| already computes positions/sizes of empty
inline boxes if it were set not to be culled (e.g., by setting
background), but the emptiness was not included in the
condition to set |ShouldCreateBoxFragment()|.

According to crbug.com/997705, legacy works in some cases,
but not in any of simplified test cases nor in other issues.

Bug: 680075, 953479, 997705
Change-Id: I1726d1a573e34d88cc91b1950bfa8e327966833c

Reviewed-on: https://chromium-review.googlesource.com/1774418
WPT-Export-Revision: a81a878e35101ad3d886a000a7dc1af28078a8f2

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/868a2300c01e
[wpt PR 18720] - [LayoutNG] Fixes positions/sizes of empty inline boxes, a=testonly

https://hg.mozilla.org/mozilla-central/rev/868a2300c01e

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.