Closed Bug 1577142 Opened 1 year ago Closed 1 year ago

search available languages doesn't work

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(thunderbird_esr6869+ fixed, thunderbird69 wontfix, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird_esr68 69+ fixed
thunderbird69 --- wontfix
thunderbird70 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Depends on 1 open bug)

Details

(Keywords: intl)

Attachments

(1 file)

Set intl.multilingual.enabled to true, and also intl.multilingual.downloadEnabled true - then restart. Go to Preferences | Advanced | General | Languages and open Set Alternatives.

Try to search available packs. Doesn't work.

TypeError: this.loadLocalesFromAMO is not a function messengerLanguages.js:347:16
onChange chrome://messenger/content/preferences/messengerLanguages.js:347
SortedItemSelectList chrome://messenger/content/preferences/messengerLanguages.js:161
TypeError: can't redefine non-configurable property "Deprecated" XPCOMUtils.jsm:316:19

Our function is called loadLocalesFromATN...

Will need bug 1490598 too for this to actually work.

Use the amo naming for easier porting in the future...

Looks like it's calling https://services.addons.thunderbird.net/api/v3/addons/language-tools/?app=thunderbird&type=language&appversion=68.0 but gets no results

Attachment #9088689 - Flags: review?(richard.marti)
Depends on: 1490598
Keywords: intl
Comment on attachment 9088689 [details] [diff] [review]
bug1577142_atn_amo.patch

Okay.
Attachment #9088689 - Flags: review?(richard.marti) → review+
Keywords: checkin-needed
Comment on attachment 9088689 [details] [diff] [review]
bug1577142_atn_amo.patch

We'll want this at some point for esr68, but it can wait some given it's not exposed before bug 1490598
Attachment #9088689 - Flags: approval-comm-esr68?

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/655929d7874a
fix function naming: use loadLocalesFromAMO() and not loadLocalesFromATN(). r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
Comment on attachment 9088689 [details] [diff] [review]
bug1577142_atn_amo.patch

Let's take it now, it doesn't matter when.
Attachment #9088689 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.