1577142 - search available languages doesn't work

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Magnus Melin [:mkmelin]]

Set intl.multilingual.enabled to true, and also intl.multilingual.downloadEnabled true - then restart. Go to Preferences | Advanced | General | Languages and open Set Alternatives.

Try to search available packs. Doesn't work.

TypeError: this.loadLocalesFromAMO is not a function messengerLanguages.js:347:16
onChange chrome://messenger/content/preferences/messengerLanguages.js:347
SortedItemSelectList chrome://messenger/content/preferences/messengerLanguages.js:161
TypeError: can't redefine non-configurable property "Deprecated" XPCOMUtils.jsm:316:19

Our function is called loadLocalesFromATN...

Will need bug 1490598 too for this to actually work.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1577142_atn_amo.patch

Use the amo naming for easier porting in the future...

Looks like it's calling https://services.addons.thunderbird.net/api/v3/addons/language-tools/?app=thunderbird&type=language&appversion=68.0 but gets no results

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 9088689 [details] [diff] [review]
bug1577142_atn_amo.patch

Okay.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9088689 [details] [diff] [review]
bug1577142_atn_amo.patch

We'll want this at some point for esr68, but it can wait some given it's not exposed before bug 1490598

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/655929d7874a
fix function naming: use loadLocalesFromAMO() and not loadLocalesFromATN(). r=Paenglab

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9088689 [details] [diff] [review]
bug1577142_atn_amo.patch

Let's take it now, it doesn't matter when.

Comment 6

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/4b35f3b24e2ff0c372d3a0fe53f4ab184ce0ec41