Closed Bug 1577193 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18724 - [LargestContentfulPaint] Fix anonymous LayoutObject aggregation

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18724 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18724
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

[LargestContentfulPaint] Fix anonymous LayoutObject aggregation

This CL allows ScopedPaintTimingDetectorBlockPaintHook to skip anonymous layout
objects by only setting |reset_top_| on the EmplaceIfNeeded() method. This also
means two DHECKs related to |top_| need to be removed.

Bug: 988593
Change-Id: Iad4cf425d712436092ed2005eb39197d7cfd8439

Reviewed-on: https://chromium-review.googlesource.com/1773720
WPT-Export-Revision: 52a495855711fa9688d53c706cd8d036b9d98539

Ran 3 tests and 3 subtests
OK     : 3
FAIL   : 3

New tests that have failures or other problems:
/element-timing/text-with-display-style.html
    Text with display style is observable.: FAIL
/largest-contentful-paint/text-with-display-style.html
    Text with display style is observable.: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/420690bcd276
[wpt PR 18724] - [LargestContentfulPaint] Fix anonymous LayoutObject aggregation, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/03fb26cf730f
[wpt PR 18724] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/420690bcd276
https://hg.mozilla.org/mozilla-central/rev/03fb26cf730f

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.