Closed Bug 1577207 Opened 5 years ago Closed 5 years ago

Overflow menu arrow is detached from the popup in customize mode

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: itiel_yn8, Assigned: bgrins)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot
21.25 KB, image/png
Details
Bug 1577207 - Set margin of 0 for the overflow menu content in customize mode in non-osx;r=Gijs
47 bytes, text/x-phabricator-request
Details | Review
Attached image Screenshot —

See attached.
Regression range is 2018-07-17 to 2018-07-18.
Mozregression couldn't bisect further.
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=afa310dc89beeb4b7a9564d2c89ff32906f427ad&tochange=5a8107262015714d2907a85abc24c847ad9b32d2

This isn't exclusive to RTL btw.

.

Flags: needinfo?(bgrinstead)
Regressed by: 1461793

Which platform(s) are you seeing this on? I just did a quick test on OSX in ltr and rtl and don't see the gap between the arrow and the popup.

Flags: needinfo?(itiel_yn8)

I(In reply to Brian Grinstead [:bgrins] from comment #3)

Which platform(s) are you seeing this on? I just did a quick test on OSX in ltr and rtl and don't see the gap between the arrow and the popup.

I'm on Windows 10. fwiw disabling the Bookmarks Toolbar doesn't help here.

Flags: needinfo?(itiel_yn8)
Priority: -- → P3

I just tested on Windows 7 and am not seeing the issue. I can check on Windows 10 later.

I realized this is only in Customize Mode, not with the actual overflow menu opened from the navbar. I can reproduce this now and will take a look.

Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Flags: needinfo?(bgrinstead)
Summary: Overflow menu arrow is detached from the popup → Overflow menu arrow is detached from the popup in customize mode

There's a 4px margin from popup.css that applies here, which causes the content to get detached
from the arrow. When popup.css used to be loaded as a XBL sheet, this stylesheet wuoldn't have
applied to the customize mode overflow menu since it's not a real <panel> but just elements in
the document sharing the same structure.

Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3dd48f49b60a
Set margin of 0 for the overflow menu content in customize mode in non-osx;r=Gijs

https://hg.mozilla.org/mozilla-central/rev/3dd48f49b60a

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: