1577217 - Enable untrusted_modules ping on beta and release

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Telemetry, enhancement, P1)

Description

[Romain Testard [:RT]]

Attachment: request.txt

Enable untrusted_modules ping on beta and release to help inform block actions.

Comment 1

[Romain Testard [:RT]]

Can you please review before I ping CHutten for approval?

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

I would like to suggest that we hold off on doing this until I land bug 1542830, and let enablement on beta and release ride along with that bug.

The reason is because the ping's schema is changing, so I'd rather that we just ride the trains with untrusted modules 2.0, rather than trying to juggle the collection of data using two schemas simultaneously.

Comment 3

[Romain Testard [:RT]]

That makes sense, marking 1542830 as blocking this bug.

Comment 4

[Arkadiusz Komarzewski [:akomar]]

Clearing my NI, nothing to add at this stage.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Taking

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1577217: Let third-party-modules ride to early beta; r=mhowell

We've decided to let this ride through to early beta. We'll evaluate how the
early beta numbers look, and if there are no significant issues we'll follow up
with another patch to ride to release.

This is already covered by the data review for bug 1542830.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fc0c2b4b909
Let third-party-modules ride to early beta; r=mhowell

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6fc0c2b4b909

Comment 9

[Toshihito Kikuchi [:toshi]]

We're still not seeing data from beta. Probably we need to remove nightly check from TelemetryImpl::GetUntrustedModuleLoadEvents, too.

Comment 10

[Jim Mathies [:jimm]]

(In reply to Toshihito Kikuchi [:toshi] from comment #9)

We're still not seeing data from beta. Probably we need to remove nightly check from TelemetryImpl::GetUntrustedModuleLoadEvents, too.

I just ran into this as well. Toshihito, would you mind picking this bug up?

Comment 11

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1577217 - Enable TelemetryImpl::GetUntrustedModuleLoadEvents in beta. r=aklotz

To enable the third-party-modules ping in beta, we need to change
TelemetryImpl::GetUntrustedModuleLoadEvents in addition to
https://hg.mozilla.org/mozilla-central/rev/6fc0c2b4b909.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0cf44dbd7d8
Enable TelemetryImpl::GetUntrustedModuleLoadEvents in beta.  r=aklotz

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e0cf44dbd7d8

Comment 14

[Toshihito Kikuchi [:toshi]]

(In reply to Jim Mathies [:jimm] from comment #10)

I just ran into this as well. Toshihito, would you mind picking this bug up?

I think necessary changes are done. This will be available in 73.0b1.

Comment 15

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1577217 - Enable the third-party-modules ping in Release build. r=aklotz

No significant issues has been reported since we enabled the ping in early beta
of 73. It's time to enable it in all versions including Release build.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73614f918c31
Enable the third-party-modules ping in Release build.  r=aklotz

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/73614f918c31