1577220 - update to the r20 NDK

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Nathan Froyd [:froydnj]]

This version of the NDK contains updated libc++ headers, which have more C++17 stuff that we need for bug 1566288 and friends.

r20 libc++ apparently has some issues with visibility macros getting changed:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3630beca44a1061589011a9d749b8f2dc47cf40&selectedJob=263882694

/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:23:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:27:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:31:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:35:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:39:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:43:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:47:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:51:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:55:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:59:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:63:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:67:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:71:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:75:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:79:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:83:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:87:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:91:8: error: visibility does not match previous declaration
/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/support/xlocale/__posix_l_fallback.h:95:8: error: visibility does not match previous declaration

which we worked around once upon a time:

https://searchfox.org/mozilla-central/source/build/moz.configure/toolchain.configure#1304-1355

but now we need to update our hacks.

It's also possible that upgrading not quite so far will still bring the libc++ features we want without the internal refactorings that break our visibility shenanigans.

Comment 1

[Nathan Froyd [:froydnj]]

r18b's headers are broken with respect to 16-bit floating-point support. r19c's headers have the same issue as r20. Time to fix things. :(

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: Bug 1577220 - update to the r20 Android NDK; r=#build

This version has a newer libc++, brings along some linker fixes, etc.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62bb12065004
update to the r20 Android NDK; r=snorp,nalexander

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/62bb12065004