Closed Bug 1577223 Opened 1 year ago Closed 5 months ago

Provide a better error for URLs without protocols

Categories

(Firefox :: Enterprise Policies, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox-esr68 71+ fixed
firefox71 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

One of the most common errors we get is invalid parameters for homepage (or bookmarks).

The error is generic, so folks can't figure it out.

We should be explicit " Value is not a URL"

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/d6079cfa0c4f
Add specific error for missing scheme in URL policies. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9094970 [details]
Bug 1577223 - Add specific error for missing scheme in URL policies.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Primarily used by policy, common error.
  • User impact if declined: Admins have trouble knowing why certain policies aren't working.
  • Fix Landed on Version: 71
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just adds an extra error check in schema.
  • String or UUID changes made by this patch:
Attachment #9094970 - Flags: approval-mozilla-esr68?

Comment on attachment 9094970 [details]
Bug 1577223 - Add specific error for missing scheme in URL policies.

Error check for policies, OK for uplift for 68.3esr.

Attachment #9094970 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

Hello,

Could it be possible to offer QA some STR in order to verify this?

Flags: needinfo?(mozilla)

Yes, sorry. A homepage policy with http:// specified:

{
"policies": {
"Homepage": {
"URL": "example.com"
}
}
}

Please the file in the distribution directory (see the top of https://github.com/mozilla/policy-templates/blob/master/README.md)

Previously it gave a generic error.

Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.