1577223 - Provide a better error for URLs without protocols

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

One of the most common errors we get is invalid parameters for homepage (or bookmarks).

The error is generic, so folks can't figure it out.

We should be explicit " Value is not a URL"

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1577223 - Add specific error for missing scheme in URL policies.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6079cfa0c4f
Add specific error for missing scheme in URL policies. r=mconley

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d6079cfa0c4f

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9094970 [details]
Bug 1577223 - Add specific error for missing scheme in URL policies.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Primarily used by policy, common error.
• User impact if declined: Admins have trouble knowing why certain policies aren't working.
• Fix Landed on Version: 71
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adds an extra error check in schema.
• String or UUID changes made by this patch:

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9094970 [details]
Bug 1577223 - Add specific error for missing scheme in URL policies.

Error check for policies, OK for uplift for 68.3esr.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/8544551ce9c7

Comment 7

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

Could it be possible to offer QA some STR in order to verify this?

Comment 8

[Mike Kaply [:mkaply]]

Yes, sorry. A homepage policy with http:// specified:

{
"policies": {
"Homepage": {
"URL": "example.com"
}
}
}

Please the file in the distribution directory (see the top of https://github.com/mozilla/policy-templates/blob/master/README.md)

Previously it gave a generic error.