1577252 - Exceptions in browser.js when editing prefs in about:config

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1. Load about:config
2. Click through the warning
3. Type "foo.bar" in the about:config search field
4. Click the "Add" button to try to add the pref

EXPECTED RESULTS: No exceptions

ACTUAL RESULTS:

JavaScript error: chrome://browser/content/content.js, line 46: TypeError: nodePrincipal.URI is null

ADDITIONAL INFORMATION: Looking at that URL locally, line 46 is:

  return nodePrincipal.isNullPrincipal || nodePrincipal.URI.schemeIs("about");

in the shouldIgnoreLoginManagerEvent function. This is the code that was added in bug 1550171, as far as I can tell. In this case nodePrincipal is a system principal, so there is no URI and the function throws an exception.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1577252 - Ignore login manager events in system principal code. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfdec1350f2e
Ignore login manager events in system principal code. r=MattN

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cfdec1350f2e

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cfdec1350f2e

Comment 5

[Cristian Fogel [:cfogel]]

In an attempt to verify the fix, I am unable to reproduce the issue.
Is there any extra pref or additional steps missing for it?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Did you have the console open?

Comment 7

[Cristian Fogel [:cfogel]]

Right, saw the error message while the browser console was open. (nightly build from 2019-08-28).
Fix verified with 71.0a1 (2019-10-13) , 70.0b14.