Closed Bug 1577271 Opened 4 months ago Closed 3 months ago

RTL fixes for the new about:logins

Categories

(Firefox :: about:logins, defect, P2)

70 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- verified
firefox71 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

Details

(Keywords: rtl, Whiteboard: [passwords:management] [skyline])

Attachments

(1 file)

No description provided.
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [passwords:management] [skyline]
Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a39095f185eb
Align the website, username and password text to the correct side while maintaining the LTR directionality r=jaws

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Status: RESOLVED → VERIFIED

Comment on attachment 9088817 [details]
Bug 1577271 - Align the website, username and password text to the correct side while maintaining the LTR directionality

Beta/Release Uplift Approval Request

  • User impact if declined: Worse RTL support in about:logins
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): HTML/CSS patch that baked for 11 days on Nightly.
  • String changes made/needed:
Attachment #9088817 - Flags: approval-mozilla-beta?

Comment on attachment 9088817 [details]
Bug 1577271 - Align the website, username and password text to the correct side while maintaining the LTR directionality

Not sure why this was landed before approval was granted, but retroactive a+ anyway.

Attachment #9088817 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified this issue on the Firefox Beta 70.0b8 (Build ID: 20190919164641) (64-bit) on Windows 7, MacOS 10.14 and Arch 4.14.

  • The website, username and password are correctly aligned and displayed when creating or editing a login on RTL builds.
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: unspecified → 70 Branch
You need to log in before you can comment on or make changes to this bug.