1577279 - mach lint complains about newtab due to eslint version mismatch

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Ed Lee :Mardak]

Looks like after doing a npm install --prefix browser/components/newtab eslint@6.2.2 at the top level m-c pulls in newtab .eslintrc.js config and newtab dependencies in particular babel-eslint that needs to be updated to support the newer eslint version.

mozilla-central/browser/components/newtab/AboutNewTabService.jsm
  162:20  error  'script' is defined but never used.  no-unused-vars (eslint)

mozilla-central/browser/components/newtab/bin/render-activity-stream-html.js
  83:15  error  'file' is defined but never used.       no-unused-vars (eslint)
  83:21  error  'templater' is defined but never used.  no-unused-vars (eslint)

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5285

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

So the fix for this adds one devDependency, and upgrades three devDevependencies in the activity-stream package.json. :Mardak checked the all the license dependencies for each changed package, and here are the results:

eslint@5.16.0 (before this patch):
Apache-2.0(4)
BSD-2-Clause(7)
BSD-3-Clause(3)
ISC(15)
MIT(82)
WTFPL OR MIT

and upgrading to eslint@6.2.2 (after this patch):
Apache-2.0(4)
BSD-2-Clause(7)
BSD-3-Clause(3)
ISC(16)
MIT(85)

so fewer types of licenses, so I guess we're okay here for eslint (and m-c uses eslint anyway)

---

babel-eslint@10.0.1 (before this patch):
Apache-2.0
BSD-2-Clause(4)
BSD-3-Clause
MIT(26)

babel-eslint@10.0.3 (after this patch):
Apache-2.0
BSD-2-Clause
BSD-3-Clause
MIT(28)

so same set

---

adding eslint-plugin-html@6.0.0 (newly added in this patch, but already exists in m-c):
BSD-2-Clause(4)
ISC(2)
MIT(6)

subset of allowed licenses

---

eslint-plugin-mozilla@1.3.0 (before this patch):
MPL-2.0
Unspecified
BSD-2-Clause(4)
ISC(2)
MIT(6)

to eslint-plugin-mozilla@2.1.0 (after this patch):
MPL-2.0
Unspecified
BSD-2-Clause(4)
ISC(2)
MIT(6)

same set… including null/undefined but I suppose this plugin is from mozilla-central anyway

Comment 3

[Mike Hoye [:mhoye]]

I don't expect this will come up often, in those cases where moving from X set of approved licenses to some pure subset of X licenses, you can just assume that's fine and proceed without me. I only need to be tagged into this stuff when we're adding new ones.

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/eb7346d52181