Closed Bug 1577310 Opened 5 months ago Closed 4 months ago

Styling is not right in event dialog time picker

Categories

(Calendar :: Dialogs, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmorris, Assigned: pmorris)

Details

Attachments

(2 files)

Attached image time-picker-styling.png

I noticed while testing bug 1569562 that the styling of the time picker in event dialog is off (at least on Linux). See screenshot showing a bad mix of light and dark backgrounds.

What version of Thunderbird and what version of Lightning do you use? What theme is enabled in Thunderbird? Is "optimize preferences for accessibility" enabled or disabled in Preferences > Calendar?

Flags: needinfo?(paul)

I just checked again and I see this on TB Daily "71.0a1 (2019-09-03)" with Lightning 71.0a1. It's the "Default" theme. I'm on GNU/Linux (Ubuntu). The styling problem is the same whether "optimize preferences for accessibility" pref is enabled or not.

Flags: needinfo?(paul)

I don't see this on my Ubuntu with Yaru theme. You could try:
.time-picker-grids {
background-color: -moz-Field;
color: -moz-FieldText;
}

This fixes it here by making the part that had a dark background have a light background. Just some left-over "anonid" selectors that didn't get updated as part of de-XBL.

Aside: I searched and found about 43 "anonid" instances in our code besides these two. So looks like we have some work to do to remove those.

Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #9093913 - Flags: review?(richard.marti)
Comment on attachment 9093913 [details] [diff] [review]
fix-time-picker-styling-0.patch

Yes, much better now.
Attachment #9093913 - Flags: review?(richard.marti) → review+
Keywords: checkin-needed
Attachment #9093913 - Flags: approval-calendar-esr?(geoff)
Attachment #9093913 - Flags: approval-calendar-beta?(geoff)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/db92650a3b47
Fix time picker styling. r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 71
Attachment #9093913 - Flags: approval-calendar-esr?(geoff)
Attachment #9093913 - Flags: approval-calendar-esr+
Attachment #9093913 - Flags: approval-calendar-beta?(geoff)
Attachment #9093913 - Flags: approval-calendar-beta+
You need to log in before you can comment on or make changes to this bug.