1577312 - Allow authentication prefs to be unlocked

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Mike Kaply [:mkaply]]

I've had requests to allow modification of authentication prefs by users.

I'm going to add a new Locked parameter that will default to true (the old way) but can be set to false.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1577312 - Allow authentication policies to be unlocked.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/931639899edd
Allow authentication policies to be unlocked. r=mconley

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/931639899edd

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9094971 [details]
Bug 1577312 - Allow authentication policies to be unlocked.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only change.
• User impact if declined: Enterprises unable to allow users to change authentication policies
• Fix Landed on Version: 71
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, automated test.
• String or UUID changes made by this patch:

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9094971 [details]
Bug 1577312 - Allow authentication policies to be unlocked.

Fix for policy issue, OK for uplift for 68.3esr.

Comment 6

[Andreea Pavel [:apavel]]

Hi Mike, the patch doesn't graft cleanly on esr68:

mozilla@ubuntu ~/mozilla-unified esr68(0) $ hg graft -er 931639899edd
grafting 569111:931639899edd "Bug 1577312 - Allow authentication policies to be unlocked. r=mconley"
merging browser/components/enterprisepolicies/Policies.jsm
merging browser/components/enterprisepolicies/schemas/policies-schema.json
merging browser/components/enterprisepolicies/tests/xpcshell/test_simple_pref_policies.js
warning: conflicts while merging browser/components/enterprisepolicies/Policies.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/enterprisepolicies/schemas/policies-schema.json! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
mozilla@ubuntu ~/mozilla-unified esr68(0+changes) $

Comment 7

[Mike Kaply [:mkaply]]

Attachment: ESR version of patch

ESR version of patch.

I built the patch, tested on ESR68 and ran eslint.

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9110904 [details]
ESR version of patch

2nd try to get this on 68.3esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/aff95af385a0