Closed Bug 1577312 Opened 1 year ago Closed 5 months ago

Allow authentication prefs to be unlocked

Categories

(Firefox :: Enterprise Policies, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox-esr68 71+ fixed
firefox71 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(2 files)

I've had requests to allow modification of authentication prefs by users.

I'm going to add a new Locked parameter that will default to true (the old way) but can be set to false.

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/931639899edd
Allow authentication policies to be unlocked. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9094971 [details]
Bug 1577312 - Allow authentication policies to be unlocked.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only change.
  • User impact if declined: Enterprises unable to allow users to change authentication policies
  • Fix Landed on Version: 71
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Policy only, automated test.
  • String or UUID changes made by this patch:
Attachment #9094971 - Flags: approval-mozilla-esr68?

Comment on attachment 9094971 [details]
Bug 1577312 - Allow authentication policies to be unlocked.

Fix for policy issue, OK for uplift for 68.3esr.

Attachment #9094971 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

Hi Mike, the patch doesn't graft cleanly on esr68:

mozilla@ubuntu ~/mozilla-unified esr68(0) $ hg graft -er 931639899edd
grafting 569111:931639899edd "Bug 1577312 - Allow authentication policies to be unlocked. r=mconley"
merging browser/components/enterprisepolicies/Policies.jsm
merging browser/components/enterprisepolicies/schemas/policies-schema.json
merging browser/components/enterprisepolicies/tests/xpcshell/test_simple_pref_policies.js
warning: conflicts while merging browser/components/enterprisepolicies/Policies.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/enterprisepolicies/schemas/policies-schema.json! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
mozilla@ubuntu ~/mozilla-unified esr68(0+changes) $

Flags: needinfo?(mozilla)
Attached file ESR version of patch

ESR version of patch.

I built the patch, tested on ESR68 and ran eslint.

Flags: needinfo?(mozilla)
Comment on attachment 9110904 [details]
ESR version of patch

2nd try to get this on 68.3esr.
Attachment #9110904 - Flags: approval-mozilla-esr68+
Attachment #9094971 - Flags: approval-mozilla-esr68+ → approval-mozilla-esr68-
You need to log in before you can comment on or make changes to this bug.