1577326 - crash reporter code does not work with the removal of `std::auto_ptr` in C++17

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Nathan Froyd [:froydnj]]

 INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/toolkit/crashreporter/client/Unified_cpp_client0.cpp:11:
ERROR -  /builds/worker/workspace/build/src/toolkit/crashreporter/client/crashreporter.cpp:29:12: error: no member named 'auto_ptr' in namespace 'std'
 INFO -  using std::auto_ptr;
 INFO -        ~~~~~^
ERROR -  /builds/worker/workspace/build/src/toolkit/crashreporter/client/crashreporter.cpp:52:8: error: no template named 'auto_ptr'
 INFO -  static auto_ptr<ofstream> gLogStream(nullptr);
 INFO -         ^
 INFO -  2 errors generated.

Ideally this is easy to fix.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1577326 - use std::unique_ptr in the crashreporter client; r=gsvelto

std::auto_ptr is going away in C++17, so we might as well switch to
the approved thing now.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a62c0eb6faa6
use std::unique_ptr in the crashreporter client; r=gsvelto

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a62c0eb6faa6

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a62c0eb6faa6