Closed Bug 1577326 Opened 3 months ago Closed 3 months ago

crash reporter code does not work with the removal of `std::auto_ptr` in C++17

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

 INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/toolkit/crashreporter/client/Unified_cpp_client0.cpp:11:
ERROR -  /builds/worker/workspace/build/src/toolkit/crashreporter/client/crashreporter.cpp:29:12: error: no member named 'auto_ptr' in namespace 'std'
 INFO -  using std::auto_ptr;
 INFO -        ~~~~~^
ERROR -  /builds/worker/workspace/build/src/toolkit/crashreporter/client/crashreporter.cpp:52:8: error: no template named 'auto_ptr'
 INFO -  static auto_ptr<ofstream> gLogStream(nullptr);
 INFO -         ^
 INFO -  2 errors generated.

Ideally this is easy to fix.

std::auto_ptr is going away in C++17, so we might as well switch to
the approved thing now.

Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a62c0eb6faa6
use std::unique_ptr in the crashreporter client; r=gsvelto
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.