Closed Bug 1577357 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18730 - Revert "Add tick duration argument to testdriver Action"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18730 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18730
Details from upstream follow.

Darren Shen <shend@chromium.org> wrote:

Revert "Add tick duration argument to testdriver Action"

This reverts commit c7ea6754ed0a642be6bbe668b6e83dbd35caecfa.

Reason for revert: Possible cause of crbug.com/998948

Original change's description:

Add tick duration argument to testdriver Action

We want to allow the users to define the duration for every tick, so we
add an argument to Action class which will be a duration for all
ticks. If there is a tick which need a different duration, we can call
addTick or pause to pass a different value.

Bug: 606367
Change-Id: I7e5d88557f5f4a4c63dbf85985c30881aee9f739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762836
Reviewed-by: Navid Zolghadr \<nzolghadr@chromium.org>
Commit-Queue: Lan Wei \<lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691186}

TBR=lanwei@chromium.org,nzolghadr@chromium.org

Change-Id: I52a0c14b77c9c6139b2f01b6a449d604fbe137d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 606367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774427
Reviewed-by: Darren Shen \<shend@chromium.org>
Commit-Queue: Darren Shen \<shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691372}

Ran 96[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt], 95[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt] tests and 153[linux64-qr-debug,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt], 154[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-opt] subtests
OK     : 43
PASS   : 123[linux64-qr-debug], 124[android-em-7.0-x86_64-opt-geckoview,linux64-opt,windows10-64-qr-debug,windows7-32-opt], 125[android-em-7.0-x86_64-debug-geckoview,linux64-asan-opt,linux64-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-opt,windows7-32-debug]
FAIL   : 27[android-em-7.0-x86_64-debug-geckoview,linux64-asan-opt,linux64-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-opt,windows7-32-debug], 28[android-em-7.0-x86_64-opt-geckoview,linux64-opt,linux64-qr-debug,windows10-64-qr-debug,windows7-32-opt]
TIMEOUT: 2[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt], 3[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
ERROR  : 49
NOTRUN : 1[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt], 2[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/pointerevents/pointerlock/pointerevent_movementxy_with_pointerlock.html
    mouse pointerevent movementX/Y with pointerlock test: FAIL[android-em-7.0-x86_64-opt-geckoview,linux64-opt,linux64-qr-debug,windows10-64-qr-debug,windows7-32-opt]

Tests that are disabled for instability:
/pointerevents/pointerevent_setpointercapture_inactive_button_mouse.html
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76ce92753ee9
[wpt PR 18730] - Revert "Add tick duration argument to testdriver Action", a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/1afc8ca1b315
[wpt PR 18730] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/76ce92753ee9
https://hg.mozilla.org/mozilla-central/rev/1afc8ca1b315

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.