1577367 - MediaController::IsPlaying() can't reflect its playing state correctly

Status: RESOLVED DUPLICATE of bug 1571493

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

If we control media controller by its public methods only, such as Play(), Pause() and Stop(), then media controller's IsPlaying() can reflect the playing state correctly.

However, if we pause controller by Pause(), but resume media from page directly, then the media controller's mIsPlaying won't be modified, so IsPlaying() would return incorrect result.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1577367 - part1 : introduce 'ControlledMediaState' to update controlled media status to media controller.

Introduce ControlledMediaState to reflect different status of controlled media.

eStarted and eStopped are used for indicating controlled media started and stopped respectively, and eResumed is used when we paused media from media controller before, but resume it from page directly via play(), then we have to update the media controller playing state.

In addition, create a class MediaControlUtils to wrap all those helper functions to show they are used for same module.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1577367 - part2 : notify media controller playback state changes when we resume paused media from page.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1577367 - part3 : only update media action to content process when we have controlled media.

Although all controllers we created and added to MediaControlService are all started, but we will support adding non-started controller to MediaControlService in the future, in order to support using MediaSession's metadata.

Therefore, add a new method to check if the controller is started.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1577367 - part5 : add test.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1577367 - part4 : change controller to 'playing' whenever new playing controlled media starts.

Controller can control multiple controlled media at the same time, if any of them is playing, then the controller should be playing as well.

Comment 6

[Phabricator Automation]

Comment on attachment 9114673 [details]
Bug 1577367 - part3 : only update media action to content process when we have controlled media.

Revision D56434 was moved to bug 1603878. Setting attachment 9114673 [details] to obsolete.

Comment 7

[Alastor Wu [:alwu]]

This issue will be fixed in bug1571493.