Not allow nsICertOverrideService to be implemented in js
Categories
(Core :: Security: PSM, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: kershaw, Assigned: kershaw)
References
Details
Attachments
(1 file)
Assignee | ||
Comment 1•3 months ago
|
||
Comment 2•3 months ago
|
||
Sorry, I’ve been on holiday. For the future, tagging r=#webdriver
will alert all the Marionette peers.
I missed an explanation in the commit message of why we’re disallowing
JS implementations of nsICertOverrideService
, but the patch looks
good and I’m sure there are entirely reasonable arguments for making
this change.
Thanks!
Assignee | ||
Comment 3•3 months ago
|
||
(In reply to Andreas Tolfsen 「:ato」 from comment #2)
Sorry, I’ve been on holiday. For the future, tagging
r=#webdriver
will alert all the Marionette peers.I missed an explanation in the commit message of why we’re disallowing
JS implementations ofnsICertOverrideService
, but the patch looks
good and I’m sure there are entirely reasonable arguments for making
this change.Thanks!
Sorry for the lack of explanation.
The main reason why we need this patch is that we want to use nsICertOverrideService off main thread, so nsICertOverrideService can't be implemented in js.
For more details, please see https://phabricator.services.mozilla.com/D28741. We made some refactoring and decided to use nsICertOverrideService off main thread.
Comment 4•3 months ago
|
||
Thanks for explaining! 👍🏻
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e0c2fea2799 Not allow nsICertOverrideService to be implemented in js r=keeler
Comment 6•3 months ago
|
||
Backed out for linting doc failure
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264750495&repo=autoland&lineNumber=708
Backout: https://hg.mozilla.org/integration/autoland/rev/951e798d04687bd40b85bb71baf2355d119cd636
Assignee | ||
Updated•3 months ago
|
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3db631b1bb1 Not allow nsICertOverrideService to be implemented in js r=keeler,ato
Comment 8•3 months ago
|
||
bugherder |
Description
•