1577428 - Not allow nsICertOverrideService to be implemented in js

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P2)

Description

[Kershaw Chang [:kershaw]]

See https://phabricator.services.mozilla.com/D43790#1322561.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1577428 - Not allow nsICertOverrideService to be implemented in js

Comment 2

[Andreas Tolfsen 「:ato」]

Sorry, I’ve been on holiday. For the future, tagging r=#webdriver
will alert all the Marionette peers.

I missed an explanation in the commit message of why we’re disallowing
JS implementations of nsICertOverrideService, but the patch looks
good and I’m sure there are entirely reasonable arguments for making
this change.

Thanks!

Comment 3

[Kershaw Chang [:kershaw]]

(In reply to Andreas Tolfsen 「:ato」 from comment #2)

Sorry, I’ve been on holiday. For the future, tagging r=#webdriver
will alert all the Marionette peers.

I missed an explanation in the commit message of why we’re disallowing
JS implementations of nsICertOverrideService, but the patch looks
good and I’m sure there are entirely reasonable arguments for making
this change.

Thanks!

Sorry for the lack of explanation.
The main reason why we need this patch is that we want to use nsICertOverrideService off main thread, so nsICertOverrideService can't be implemented in js.
For more details, please see https://phabricator.services.mozilla.com/D28741. We made some refactoring and decided to use nsICertOverrideService off main thread.

Comment 4

[Andreas Tolfsen 「:ato」]

Thanks for explaining! 👍🏻

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e0c2fea2799
Not allow nsICertOverrideService to be implemented in js r=keeler

Comment 6

[Andreea Pavel [:apavel]]

Backed out for linting doc failure

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=2e0c2fea279919e3174d61815302a4d197ae9de7&selectedJob=264750495

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264750495&repo=autoland&lineNumber=708

Backout: https://hg.mozilla.org/integration/autoland/rev/951e798d04687bd40b85bb71baf2355d119cd636

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3db631b1bb1
Not allow nsICertOverrideService to be implemented in js r=keeler,ato

Comment 8

[Bogdan Tara[:bogdan_tara]]

https://hg.mozilla.org/mozilla-central/rev/a3db631b1bb1