Closed Bug 1577428 Opened 3 months ago Closed 3 months ago

Not allow nsICertOverrideService to be implemented in js

Categories

(Core :: Security: PSM, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

Details

Attachments

(1 file)

Sorry, I’ve been on holiday. For the future, tagging r=#webdriver
will alert all the Marionette peers.

I missed an explanation in the commit message of why we’re disallowing
JS implementations of nsICertOverrideService, but the patch looks
good and I’m sure there are entirely reasonable arguments for making
this change.

Thanks!

(In reply to Andreas Tolfsen 「:ato」 from comment #2)

Sorry, I’ve been on holiday. For the future, tagging r=#webdriver
will alert all the Marionette peers.

I missed an explanation in the commit message of why we’re disallowing
JS implementations of nsICertOverrideService, but the patch looks
good and I’m sure there are entirely reasonable arguments for making
this change.

Thanks!

Sorry for the lack of explanation.
The main reason why we need this patch is that we want to use nsICertOverrideService off main thread, so nsICertOverrideService can't be implemented in js.
For more details, please see https://phabricator.services.mozilla.com/D28741. We made some refactoring and decided to use nsICertOverrideService off main thread.

Thanks for explaining! 👍🏻

Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e0c2fea2799
Not allow nsICertOverrideService to be implemented in js r=keeler
Flags: needinfo?(kershaw)
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3db631b1bb1
Not allow nsICertOverrideService to be implemented in js r=keeler,ato
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.