Closed
Bug 157750
Opened 22 years ago
Closed 22 years ago
Crash when reading certain encrypted S/Mime messages
Categories
(NSS :: Libraries, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
3.5
People
(Reporter: KaiE, Assigned: wtc)
Details
(Keywords: crash, Whiteboard: [ADT2 RTM])
Attachments
(2 files)
The crash might depend on my particular cert db, but I will test with a new cert db, after importing my private key. I only see it with one particular message. The crash is in pk11_fastCert. An object "co" created by nssCryptokiObject_Create contains a NULL co->label. The function tries to execute PORT_strlen on that NULL pointer and crashes. I'm attaching the stack trace.
Reporter | ||
Comment 1•22 years ago
|
||
Assignee | ||
Comment 2•22 years ago
|
||
Bob, is it normal for a nssCryptokiObject created by nssCryptokiObject_Create to have a null "label" field?
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → 3.6
Version: unspecified → 3.5
Reporter | ||
Comment 3•22 years ago
|
||
I tried with a fresh profile and imported my p12 file. Using it I can read the message and do not crash. This means, this bug is about migrated profiles. I don't believe my NSS cert database is corrupted. I have been using it for a while, and every other operation correctly succeeds. Unfortunately, I can't give you the cert database, as it contains my personal private keys.
Comment 4•22 years ago
|
||
Yes, it's possible for some certs not to have a label (peer certs). That appears to be the type of cert kaie is looking at. Why it hasn't crashed before is a mystery to me (probably because you can dereference through a NULL pointer on NT). This patch should restore the expected behaviour. bob
Reporter | ||
Comment 5•22 years ago
|
||
Thanks, Bob! This patch fixes the crash for me.
Reporter | ||
Comment 6•22 years ago
|
||
Comment on attachment 91524 [details] [diff] [review] Don't return a nickname if there isn't a nickname to return. r=kaie Obvious null check.
Attachment #91524 -
Flags: review+
Assignee | ||
Comment 7•22 years ago
|
||
Comment on attachment 91524 [details] [diff] [review] Don't return a nickname if there isn't a nickname to return. r=wtc. By the way, the pk11_fastCert function should be made static because it's not used outside the pk11cert.c file. Kai, could you test this patch?
Reporter | ||
Comment 8•22 years ago
|
||
Yes, I tested the patch and it fixes the crash.
Reporter | ||
Comment 9•22 years ago
|
||
nominating as a very important crash fix, as this seems to happen to some people very often.
Whiteboard: [ADT1 RTM]
Comment 10•22 years ago
|
||
adding adt1.0.1+ and lowering to an adt2. Please get drivers approval before checking into the branch.
Comment 11•22 years ago
|
||
Comment on attachment 91524 [details] [diff] [review] Don't return a nickname if there isn't a nickname to return. a=chofmann for 1.1a trunk and 1.0.1 branch.
Attachment #91524 -
Flags: approval+
Updated•22 years ago
|
Keywords: mozilla1.0.1 → mozilla1.0.1+
Assignee | ||
Comment 12•22 years ago
|
||
The fix has been checked into the tip, NSS_3_5_BRANCH, NSS_CLIENT_TAG, and MOZILLA_1_0_BRANCH of NSS. Should I add the fix1.0.1 keyword?
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: 3.6 → 3.5
Comment 14•22 years ago
|
||
Verified 20020826 Branch build.
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.1 → verified1.0.1
You need to log in
before you can comment on or make changes to this bug.
Description
•