Closed Bug 1577504 Opened 1 year ago Closed 1 year ago

Fix clippy lint issues for mozrunner

Categories

(Testing :: Mozbase Rust, task, P2)

Product:
Testing
Component:
Mozbase Rust
Version:
Version 3
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: dheiberg, Assigned: dheiberg)

Details

Attachments

(4 files)

Bug 1577504 - Remove redundant field names r=jgraham
47 bytes, text/x-phabricator-request
Details | Review
Bug 1577504 - Remove explicit lifetimes that can be elided r=jgraham
47 bytes, text/x-phabricator-request
Details | Review
Bug 1577504 - Remove redundant closures r=jgraham
47 bytes, text/x-phabricator-request
Details | Review
Bug 1577504 - Replace single match with if let r=jgraham
47 bytes, text/x-phabricator-request
Details | Review

As part of the effort to have Geckodriver and supporting crates pass Clippy linting, we should fix the lint issues raised in mozrunner.

Related to https://bugzilla.mozilla.org/show_bug.cgi?id=1575263

Assignee: nobody → dheiberg
Component: geckodriver → Mozbase Rust
Priority: -- → P2

When there is an input of either &self or &mut self, its lifetime is automatically assigned to the elided output lifetimes

Depends on D45355

Depends on D45356

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/e52b51cf6569
Remove redundant field names r=jgraham
https://hg.mozilla.org/integration/autoland/rev/ed5978118f06
Remove explicit lifetimes that can be elided r=jgraham
https://hg.mozilla.org/integration/autoland/rev/abda0958db89
Remove redundant closures r=jgraham
https://hg.mozilla.org/integration/autoland/rev/cc25750fd9e8
Replace single match with if let r=jgraham
You need to log in before you can comment on or make changes to this bug.