Closed Bug 1577506 Opened 5 years ago Closed 2 years ago

Broken photo slideshow transition

Categories

(Core :: CSS Transitions and Animations, defect, P3)

70 Branch
Desktop
Windows 10
defect

Tracking

()

VERIFIED WORKSFORME
Tracking Status
firefox70 --- affected

People

(Reporter: oanaarbuzov, Unassigned)

References

()

Details

Attachments

(3 files)

Attached image TransitionAnimation.gif

Environment
Browser / Version: Firefox Nightly 70.0a1 (2019-08-28)
Operating System: Windows 10 Pro

Steps to reproduce:
1. Navigate to https://www.msn.com/en-xl/asia/photos/shockingly-realistic-robots/ss-AAxiMLu#image=7
2. Click the photo slideshow arrows.
3. Observe slide transition.

Expected Behavior:
Slide transition is smooth.

Actual Behavior:
Slide transition is broken (previous photo seems to be displayed again in between the slides).

Note
1. Not reproducible on Chrome 76.0.3809.132.
2. Gif attached.
3. Created performance profile.

Affected area:

<article class="flex gallery-container none loaded" data-aop="galleryflex" data-id="46" data-m="{&quot;i&quot;:46,&quot;p&quot;:45,&quot;n&quot;:&quot;gallery&quot;,&quot;y&quot;:8,&quot;o&quot;:1}" role="application" data-nativead-placements="article_aside:3;singlecard1:1;singlecard2:1;singlecard3:1;singlecard4:1;singlecard5:1;singlecard6:1;singlecard7:1;singlecard8:1;singlecard9:1;singlecard10:1;singlecard11:1;" aria-label="slideshow">
	<section class="gallery unselectable" data-aop="galleryflex_slide" data-click-behavior="GoToNextSlide">
		<ul class="slideshow loaded" role="list" data-next-url="/en-xl/asia/life-arts/hilarious-and-memorable-dialogues-from-superhero-films/ss-BBUl4Lj" tabindex="0" style="width: 17977.5px; transform: translateX(-799px);">
			<li class="">
				<div class="imgcontainer" data-image-size="2500,1779" data-id="47" data-m="{&quot;i&quot;:47,&quot;p&quot;:46,&quot;n&quot;:&quot;image1&quot;,&quot;y&quot;:14,&quot;o&quot;:1}">
		    		<img alt="Slide 1 of 22: The HRP-4C humanoid robot &quot;Miim&quot; presents a wedding dress by Japanese designer Yumi Katsura during the 2009 Yumi Katsura Paris Grand Collection in Osaka, western Japan, July 22, 2009. REUTERS/Toru Hanai (JAPAN ENTERTAINMENT SOCIETY SCI TECH)" data-src="{&quot;default&quot;:&quot;//img-s-msn-com.akamaized.net/tenant/amp/entityid/AAx8YPp.img?h=416&amp;w=799&amp;m=6&amp;q=60&amp;u=t&amp;o=f&amp;l=f&amp;x=752&amp;y=507&quot;,&quot;size3column&quot;:&quot;//img-s-msn-com.akamaized.net/tenant/amp/entityid/AAx8YPp.img?h=416&amp;w=624&amp;m=6&amp;q=60&amp;u=t&amp;o=f&amp;l=f&amp;x=752&amp;y=507&quot;,&quot;size2column&quot;:&quot;//img-s-msn-com.akamaized.net/tenant/amp/entityid/AAx8YPp.img?h=416&amp;w=624&amp;m=6&amp;q=60&amp;u=t&amp;o=f&amp;l=f&amp;x=752&amp;y=507&quot;}" role="presentation" src="https://img-s-msn-com.akamaized.net/tenant/amp/entityid/AAx8YPp.img?h=416&amp;w=799&amp;m=6&amp;q=60&amp;u=t&amp;o=f&amp;l=f&amp;x=752&amp;y=507" title="Miim - Toru Hanai/Reuters" class="loaded">
				</div>
			</li>
			<li class="show">
				<div class="imgcontainer" data-image-size="4207,2805" data-id="48" data-m="{&quot;i&quot;:48,&quot;p&quot;:46,&quot;n&quot;:&quot;image2&quot;,&quot;y&quot;:14,&quot;o&quot;:2}">
					<img alt="Slide 2 of 22: TORONTO, ON - APRIL 30: Saudi Arabian citizen Humanoid Robot Sophia is seen during the Discovery exhibition on April 30, 2018 in Toronto, Canada. (Phoo by Yu Ruidong/China News Service/VCG via Getty Images)" data-src="{&quot;default&quot;:{&quot;load&quot;:&quot;wait&quot;,&quot;src&quot;:&quot;//img-s-msn-com.akamaized.net/tenant/amp/entityid/AAx9kxh.img?h=416&amp;w=799&amp;m=6&amp;q=60&amp;u=t&amp;o=f&amp;l=f&amp;x=2659&amp;y=963&quot;},&quot;size3column&quot;:{&quot;load&quot;:&quot;wait&quot;,&quot;src&quot;:&quot;//img-s-msn-com.akamaized.net/tenant/amp/entityid/AAx9kxh.img?h=416&amp;w=624&amp;m=6&amp;q=60&amp;u=t&amp;o=f&amp;l=f&amp;x=2659&amp;y=963&quot;},&quot;size2column&quot;:{&quot;load&quot;:&quot;wait&quot;,&quot;src&quot;:&quot;//img-s-msn-com.akamaized.net/tenant/amp/entityid/AAx9kxh.img?h=416&amp;w=624&amp;m=6&amp;q=60&amp;u=t&amp;o=f&amp;l=f&amp;x=2659&amp;y=963&quot;}}" role="presentation" src="https://img-s-msn-com.akamaized.net/tenant/amp/entityid/AAx9kxh.img?h=416&amp;w=799&amp;m=6&amp;q=60&amp;u=t&amp;o=f&amp;l=f&amp;x=2659&amp;y=963" title="Sophia - Yu Ruidong/China News Service/VCG via Getty Images" class="loaded">
				</div>
			</li>
<!--cut out-->
</article>

Added Performance profile file.

I'm not sure this is actually a performance bug. I think it's to do with the app triggering multiple transitions on the same element when it only intends to trigger one.

I haven't debugged why it is triggering multiple transitions on Firefox and not on other browsers, however.

Adding webcompat:needs-diagnosis flag since this really needs someone to work out which of the millions of scripts on this page is triggering the transition so we can work out why the behavior differs.

note that it doesn't reproduce on macbook. At least i have not been able myself to reproduce.

I think the new DOM mutation breakpoints feature (prefs: devtools.debugger.features.dom-mutation-breakpoints, devtools.markup.mutationBreakpoints.enabled) could be helpful in diagnosing this. We just need to watch for attribute modifications on the ul.slideshow.loaded element from the above screenshot since the transitions appear to be triggered by directly modifying inline style.

In https://static-entertainment-eas-s-msn-com.akamaized.net/en-xl/asia/_sc/js/b443689a-/direction=ltr.locales=en-xl.themes=gray.dpi=resolution1x/f4-e42a4c-b6b963f9/a9-b72240-dc19049b/54-6d4bd1-c1499028/94-8810e8-30e5d44b/d9-222405-5599dabd/7e-a2fde3-e76dbcc3/9e-a7a255-68ddb2ab/a9-ac9b58-68ddb2ab/f7-c2f82d-68ddb2ab/f1-d0c6aa-cae48929/c7-47822a-f41d9e92/42-9a3c0c-2f6d6d18/fd-902ccf-5292562a/6b-84a214-68ddb2ab/78-2604b1-68ddb2ab/6e-a08f97-68ddb2ab?ver=20190824_17864432&fdhead=msnallexpusers,muidflt26cf,muidflt28cf,muidflt53cf,muidflt301cf,muidflt313cf,oneboxdhpcf,platagyedge2cf,audexedge1cf,article4cf,jslltelemetry,routesportssf&csopd=20180321085328&csopdb=20190830195056

this is partly controlled by.

function gt(t) {
  var i = k.eq(t),
    r = sr.eq(t),
    u = hr.eq(t),
    f;
  (it != undefined &&
    ct != undefined &&
    i.hasClass(w) &&
    r.hasClass(w) &&
    u.hasClass(w)) ||
    ((f = n("img", i).attr("alt")),
    or.text(f),
    it &&
      it.hasClass(w) &&
      ct.hasClass(w) &&
      (it.removeClass(w),
      pi.removeClass(w),
      wt
        ? ri
            .stop(!0, !0)
            .animate(
              {
                opacity: "0"
              },
              150
            )
            .removeClass("update")
        : ct.removeClass(w)),
    (it = i.addClass(w)),
    (pi = u.addClass(w)),
    wt && ct
      ? setTimeout(function() {
          ct.removeClass(w);
          ct = r.addClass(w);
          ri.stop(!0, !0)
            .css("opacity", 1)
            .addClass("update");
        }, 150)
      : (ct = r.addClass(w)),
    a.adjustThumbnailContainer(it, fi),
    n("img", ct).each(function() {
      oi(this);
    }),
    vt || (ht.scrollTop(0), wt && gr()));
}

Hmm, none of that appears to be setting the transform in inline style (or at least not directly).

Webcompat Priority: --- → ?

Doesn't seem like this is still a performance issue anymore, the site moves smoothly for me. Closing for now, but please reopen if this still happens.

Status: NEW → RESOLVED
Closed: 2 years ago
Webcompat Priority: ? → ---
Resolution: --- → WORKSFORME

I can confirm that the slideshow transition runs smoothly now.

Tested with:
Browser / Version: Firefox Nightly 105.0a1 (2022-07-27)
Operating System: Windows 10 Pro

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: