Closed
Bug 1577567
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 18754 - Implement checks in the proper order in XR::requestSession
Categories
(Testing :: web-platform-tests, task, P4)
Testing
web-platform-tests
Tracking
(firefox71 fixed)
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 18754 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/18754
Details from upstream follow.
Will Cassella <cassew@google.com> wrote:
Implement checks in the proper order in XR::requestSession
The number and ordering of checks in XR::requestSession was not
compliant with the spec. This CL fixes that. There is still a remaining
issue around multiple immersive requests from different pages
simultaneously, but that should be done as separate work.Link to relevant spec section:
https://immersive-web.github.io/webxr/#dom-xr-requestsessionBug: 962991, 987073
Change-Id: I590eed311583542ceadc208047e40c3bf260e421
Reviewed-on: https://chromium-review.googlesource.com/1764325
WPT-Export-Revision: 8f9e0f1cf10044374ab12f31d88bbaa98a859853
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=58fb7e4e3062669b923ca30eba9e043d9a43e86c
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5f4507307deae2fb9528febcc05d32e648fe2a8
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d4e36fe344d2bd4837825001acd8cdcdf126b45
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b585aa2710413e73c380ddf07f6f8b3b6843e160
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=90b3ef2f8b44cc251ef27c6c560c925f089258b8
|
|
Assignee | |
Comment 6•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2cda52ab52140956b564e0b5d155be7e33a129a
|
|
Assignee | |
Comment 7•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=234db8d7d0e517d2a0b3724c559b3073c6ac0eb4
|
|
Assignee | |
Comment 8•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e10e1fff00716cec4e7670798b31df31e440496f
|
|
Assignee | |
Comment 9•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=91fbf092ffd423d74f3f7a13644115a197860078
|
|
Assignee | |
Comment 10•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=30850a0b84ff02d022cc8fd1e85ac6c5427ae6f6
|
|
Assignee | |
Comment 11•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8df99dac57a25570a237a885aeee81a26f5e0247
|
|
Assignee | |
Comment 12•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebd40121efe664f27d8b08d1d3c2b91b678112a7
|
|
Assignee | |
Comment 13•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7514f543eb0a325efdd7f34f21128655c2ed4aa6
|
|
Assignee | |
Comment 14•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8a8edbde98812876ac83ac92af1b85ebd334149
|
|
Assignee | |
Comment 15•5 years ago
|
||
Ran 1 tests and 1[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt] subtests
OK : 1[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
FAIL : 1[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
New tests that have failures or other problems:
/webxr/xrSession_viewer_availability.https.html
Inline viewer support with no device: FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
Tests that are disabled for instability:
/webxr/xrSession_viewer_availability.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
|
||
Comment 16•5 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/18f7a250daa8 [wpt PR 18754] - Implement checks in the proper order in XR::requestSession, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/d8c09941e541 [wpt PR 18754] - Update wpt metadata, a=testonly
|
||
Comment 17•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/18f7a250daa8
https://hg.mozilla.org/mozilla-central/rev/d8c09941e541
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•