Closed Bug 1577582 Opened 5 years ago Closed 5 years ago

QFB selector "Any of/All of" much too high (TB 68)

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr6869+ fixed, thunderbird69 wontfix, thunderbird70 fixed)

Status:
VERIFIED FIXED
Milestone:
Thunderbird 70.0
Tracking Flags:
Tracking Status
thunderbird_esr68 69+ fixed
thunderbird69 --- wontfix
thunderbird70 --- fixed

People

(Reporter: jorgk-bmo, Assigned: Paenglab)

Details

Attachments

(1 file, 2 obsolete files)

1577582-hide-qfb-tag-button-icon.patch
1.70 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-esr68+
Details | Diff | Splinter Review

QFB selector "Any of/All of" much too high

Flags: needinfo?(richard.marti)

Also seen on trunk.

This fixes it for me.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9089157 - Flags: review?(jorgk)
Attachment #9089157 - Flags: approval-comm-esr68?
Attachment #9089157 - Flags: approval-comm-beta?
Comment on attachment 9089157 [details] [diff] [review]
1577582-hide-qfb-tag-button-icon.patch

Hmm, that fixes the height, but the labels on the buttons, "Important", "Work", etc. don't line up horizontally with "All/Any of".
Attachment #9089157 - Flags: review?(jorgk)
Attachment #9089157 - Attachment is obsolete: true
Attachment #9089157 - Flags: approval-comm-esr68?
Attachment #9089157 - Flags: approval-comm-beta?
Attachment #9089179 - Flags: review?(jorgk)
Attachment #9089179 - Flags: approval-comm-esr68?
Attachment #9089179 - Flags: approval-comm-beta?

Or like this?

Attachment #9089179 - Attachment is obsolete: true
Attachment #9089179 - Flags: review?(jorgk)
Attachment #9089179 - Flags: approval-comm-esr68?
Attachment #9089179 - Flags: approval-comm-beta?
Attachment #9089185 - Flags: review?(jorgk)
Attachment #9089185 - Flags: approval-comm-esr68?
Attachment #9089185 - Flags: approval-comm-beta?
Comment on attachment 9089185 [details] [diff] [review]
1577582-hide-qfb-tag-button-icon.patch

For my taste it could be still 1-2 px lower, but I can't see how to achieve this.
Attachment #9089185 - Flags: review?(jorgk)
Attachment #9089185 - Flags: review+
Attachment #9089185 - Flags: approval-comm-esr68?
Attachment #9089185 - Flags: approval-comm-esr68+
Attachment #9089185 - Flags: approval-comm-beta?
Attachment #9089185 - Flags: approval-comm-beta+
Target Milestone: --- → Thunderbird 70.0
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6d19644e6289
Hide the toolbarbutton-icon on the QFB tag buttons. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Looks OK in the ESR, but TB 60 looked better.

Status: RESOLVED → VERIFIED
Attachment #9089185 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: